Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

additional date german#1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ltdeta wants to merge2 commits intojquery-validation:master
base:master
Choose a base branch
Loading
fromltdeta:dateGER
Open

additional date german#1849

ltdeta wants to merge2 commits intojquery-validation:masterfromltdeta:dateGER

Conversation

@ltdeta
Copy link

adopted from additional dateITA

adopted from dateITA
check = false;
}
} else {
check = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please remove the else block. the var is already initialised with this value.

@staabmstaabmforce-pushed themaster branch 2 times, most recently fromd621aab to3861ce2CompareSeptember 26, 2016 14:28
@staabm
Copy link
Member

Thx for the PR. Please add tests

@stale

This comment has been minimized.

@stalestalebot added the staleUsed to mark stale issues labelJun 5, 2018
@ltdeta
Copy link
Author

ltdeta commentedJun 7, 2018•
edited
Loading

Thx for the PR. Please add tests

What does it actually mean ?

@stalestalebot removed the staleUsed to mark stale issues labelJun 7, 2018
@Arkni
Copy link
Member

Hi@ltdeta,

It means you need to add some test for the new method, like it's done withdateITA in

QUnit.test("dateITA",function(assert){
varmethod=methodTest("dateITA");
assert.ok(method("01/01/1900"),"Valid date ITA");
assert.ok(method("17/10/2010"),"Valid date ITA");
assert.ok(!method("01/13/1990"),"Invalid date ITA");
assert.ok(!method("01.01.1900"),"Invalid date ITA");
assert.ok(!method("01/01/199"),"Invalid date ITA");
});

@ltdeta
Copy link
Author

Here are some tests for the new method

QUnit.test( "dateGER", function( assert ) {var method = methodTest( "dateGER" );assert.ok( method( "01.01.1900" ), "Valid date GER" );assert.ok( method( "17.10.2010" ), "Valid date GER" );assert.ok( method( "17.6.1878" ), "Valid date GER" );assert.ok( method( "2.6.1870" ), "Valid date GER" );assert.ok( !method( "01.13.1990" ), "Invalid date GER" );assert.ok( !method( "32.05.1990" ), "Invalid date GER" );assert.ok( !method( "00.01.1900" ), "Invalid date GER" );assert.ok( !method( "01.02.199" ), "Invalid date GER" );        assert.ok( !method( "01.02.99" ), "Invalid date GER" );assert.ok( !method( "00.00.1900" ), "Invalid date GER" );assert.ok( !method( "0.00.1900" ), "Invalid date GER" );assert.ok( !method( "0.0.1900" ), "Invalid date GER" );} );

@Arkni
Copy link
Member

HI@ltdeta,

Sorry for taking so long to respond to you comment. Can you please add those tests after

QUnit.test("dateITA",function(assert){
varmethod=methodTest("dateITA");
assert.ok(method("01/01/1900"),"Valid date ITA");
assert.ok(method("17/10/2010"),"Valid date ITA");
assert.ok(!method("01/13/1990"),"Invalid date ITA");
assert.ok(!method("01.01.1900"),"Invalid date ITA");
assert.ok(!method("01/01/199"),"Invalid date ITA");
});
and push the changes.

After that I will merge the PR.

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ltdeta@staabm@Arkni
[8]ページ先頭
©2009-2025 Movatter.jp