@Arkni do you consider adding a unit test? I am also ok to land this as is.

@RoBorg could you confirm that this patch fixes the issue you observed?

@staabm yup that will fix it

@staabm I will try to extenddestroy's unit test.

I added some tests :)

Nice. Did you make sure the tests fail without the patch?

Yep, I did :)

merged thx. not sure why git wasnt able to fast forward it... required a merged commit..

I'm not sure why this happen.

TheGit's docs give us a good reason:

Because the commit on the branch you’re on isn’t a direct ancestor of the branch you’re merging in, Git has to do some work. In this case, Git does a simple three-way merge, using the two snapshots pointed to by the branch tips and the common ancestor of the two.

If you want, you can reset the master and delete the last 2 commit (including the merge commit) and I will create another PR based on new master.

No worries, its fine