Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Aditional: case-insensitive check for BIC#1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Arkni wants to merge2 commits intojquery-validation:masterfromArkni:pr/1547

Conversation

@Arkni
Copy link
Member

Squashed and rebased#1547.
The authorship still maintained. So you canclose#1547 in favor of this one

I found no appearant reason why a BIC has to be all-upper,so allowing customers to enter it lowercase or mixed should be ok.Furthermore, the IBAN-validation also is case-insensitive.Closesjquery-validation#1547
@staabm
Copy link
Member

@Arkni would you mind adding a unit test?

@Arkni
Copy link
MemberAuthor

will do when time allows.

@Arkni
Copy link
MemberAuthor

@staabm
Done!

@staabm
Copy link
Member

thx. next step for me is learning "how to merge it right" ;)

@Arkni
Copy link
MemberAuthor

next step for me is learning "how to merge it right" ;)

Yep 😁

@staabm
Copy link
Member

Achievement unlocked :-)

merged as3f3fb8cc5ccf06

next time I will try to let the commit message autoclose the PR :-).

@staabmstaabm closed thisNov 9, 2015
@ArkniArkni deleted the pr/1547 branchNovember 9, 2015 12:07
@Arkni
Copy link
MemberAuthor

Achievement unlocked :-)

Good :D

next time I will try to let the commit message autoclose the PR :-).

Yes, it helps avoiding closing issues and PR manually.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Arkni@staabm@netzkind
[8]ページ先頭
©2009-2025 Movatter.jp