Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
case-insensitive check for BIC#1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I found no appearant reason why a BIC has to be all-upper, so allowing customers to enter it lowercase or mixed should be ok.Furthermore, the IBAN-validation also is case-insensitive.
staabm commentedAug 12, 2015
For consistency with IBAN I agree. I think we should add in the comments of both validations that the validation is handled in a case-insensitive manner and that it is up to the user to normalize the input (e.g. convert everything into uppercase before persisting the user input). |
netzkind commentedAug 12, 2015
Sounds good to me. Will you need an amended pull request/patch? |
staabm commentedAug 12, 2015
please add the requested change to this PR. |
netzkind commentedAug 12, 2015
OK, comments are amended. |
staabm commentedAug 21, 2015
Thanks, your changes look good to me. |
staabm commentedSep 9, 2015
@netzkind could your squash those commits? |
staabm commentedSep 11, 2015
@netzkind please squash your commits and prefix the commit message with I will merge after this small changes. |
staabm commentedOct 21, 2015
@netzkind are you willing to apply the above mentioned changes? |
I found no appearant reason why a BIC has to be all-upper,so allowing customers to enter it lowercase or mixed should be ok.Furthermore, the IBAN-validation also is case-insensitive.Closesjquery-validation#1547
I found no appearant reason why a BIC has to be all-upper, so allowing customers to enter it lowercase or mixed should be ok.
Furthermore, the IBAN-validation also is case-insensitive.