Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Additionals: Added maxsize plugin#1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Additionals: Added maxsize plugin#1512
Uh oh!
There was an error while loading.Please reload this page.
Conversation
eaca996 toe2ea371Comparejzaefferer commentedJul 20, 2015
Thank you for the contribution. This looks like a good start, but very much needs tests. There is an open PR that added tests for the accept method (#1373) and one more that further extends the method (#1441). Both need some rebasing or other fixes to get merged. Could I interest you in that? If so, start with the accept PRs (rebase and whatever else is needed), then rebase this PR on top and share the testing infrastructure (the |
twolfson commentedJul 20, 2015
imo, per-computer filetype validation isn't too trustworthy as it can change a lot from computer to computer (e.g. we have seen Is there anything that needs to be done in#1373 aside from a squash/rebase? |
jzaefferer commentedJul 20, 2015
No, I think that's all there is to it. |
twolfson commentedJul 20, 2015
Is there any reason why I should do it over you? I am not quite sure I follow the problem =/ The attribution should still be preserved -- here is an example in |
twolfson commentedJul 21, 2015
If you are unfamiliar with how to grab commits from a PR outside of GitHub, here is a gist describing the details: |
jzaefferer commentedJul 21, 2015
The problem are the 7 commits on that PR, of which at least three produce conflicts during a rebase. I figured you could help resolve those, since you'd likely end up integrating some of those changes into your own PR anyway. |
twolfson commentedJul 22, 2015
Taking a shot at getting#1373 back on its feet |
ghost commentedSep 22, 2016 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
@jzaefferer@twolfson Please look at#6834. |
twolfson commentedSep 23, 2016
This PR was opened over a year ago, I no longer work at the organization I started it from, and I no longer have time to contribute to this PR. Closing this PR -- someone can pull over the changes into another PR if they want them |
We recently created a maxsize plugin to detect that a file is too large before submission. Based off of#450 and#1111, it looks like other people would like it as well. In this PR:
src/additionalMissing:
We didn't add any tests as there are no tests for the only other
FileListbased plugin (accept.js). I am assuming that the reason for this is we cannot programmatically tell a browser where to get our file uploads from.