Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Fixed bug #697: Remote validation uses wrong error messages#1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Arkni commentedNov 8, 2015
@denisson test("Fix #697: remote validation uses wrong error messages",function(assert){vare=$("#username"),done1=assert.async(),done2=assert.async(),done3=assert.async(),v=$("#userForm").validate({rules:{username:{required:true,remote:{url:"users.php"}}},messages:{username:{remote:$.validator.format("{0} in use")}}});$("#userForm").valid();e.val("Peter");v.element(e);setTimeout(function(){equal(v.errorList[0].message,"Peter in use");done1();e.val("something");v.element(e);e.val("Peter");v.element(e);setTimeout(function(){equal(v.errorList[0].message,"Peter in use");done2();e.val("asdf");v.element(e);setTimeout(function(){equal(v.errorList[0].message,"asdf in use","error message should be updated");done3();});});});}); NB: You should also rebase the PR on top of |
staabm commentedNov 9, 2015
Arkni commentedNov 24, 2015
@denisson |
denisson commentedNov 24, 2015
@Arkni |
Arkni commentedDec 22, 2015
@denisson any update on this? |
denisson commentedDec 22, 2015
I am having problems with commitplease. I guess I'm doing something wrong. On Tue, Dec 22, 2015 at 11:25 AM, Brahim Arkninotifications@github.com
|
Arkni commentedDec 22, 2015
You have to start your commit message with |
This change doesn't break any existing unit test, but there is no additional tests. It would be great if somebody could create these tests, because I don't know how to do it.