NotificationsYou must be signed in to change notification settings
Fork20.5k
Star59.7k

Docs: Create Bug and Feature Request Forms#5651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

adityaraute wants to merge8 commits intojquery:main

base:main

Choose a base branch

fromadityaraute:patch-1

Open

Docs: Create Bug and Feature Request Forms#5651

adityaraute wants to merge8 commits intojquery:mainfromadityaraute:patch-1

Conversation

Copy link

adityaraute commentedApr 6, 2025

Summary

Fixes#5650
Adds a new Issue Form for Feature Requests

Checklist

New tests have been added to show the fix or feature works
If needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com

Create Feature Request.yml

759b93b

Copy link

linux-foundation-easyclabot commentedApr 6, 2025•
edited
Loading

The committers listed above are authorized under a signed CLA.

✅ login: adityaraute / name: Aditya Raute (759b93b,36137ea,fe9d32b,cf382a1,4942c28,2d51618,10e4eea,6a808cf)

Add link to the Wiki Page

4942c28

adityaraute marked this pull request as ready for review

April 6, 2025 09:34

Copy link

Member

mgol commentedApr 6, 2025

Thanks for the PR. Please sign our CLA, we cannot merge contributed code otherwise.

adityaraute changed the title~~Create Feature Request.yml~~Create Feature Request Issue Form

Apr 7, 2025

Copy link

Author

adityaraute commentedApr 7, 2025

Thanks for the PR. Please sign our CLA, we cannot merge contributed code otherwise.

Done!

mgol requested changes

Apr 13, 2025

View reviewed changes

Copy link

Member

mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR.

I tried this on my fork but it doesn't work. I recommend you to temporarily enable issues on your jQuery fork and to set thepatch-1 branch as the main one and you'll be able to check what's needed. In particular, I think we need aconfig.yml file:https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser

Also, if we want to introduce a feature request form, please make sure the path to report regular bug reports is at least not harder than it was - maybe we need to create a form for bug reports as well, even if for now it won't ask that many questions (we can always improve it later)?

Copy link

Author

adityaraute commentedApr 15, 2025

I recommend you to temporarily enable issues on your jQuery fork and to set the patch-1 branch as the main one and you'll be able to check what's needed.

I had done this before creating the PR. Not sure what's the issue is about. I'll look into the link you shared.

maybe we need to create a form for bug reports as well

I'll add in this PR itself

adityaraute marked this pull request as draft

April 15, 2025 20:20

adityaraute added6 commits

April 15, 2025 21:26

Fix a syntax error in Issue Form

6a808cf

Fix Typo in Feature Form

fe9d32b

Create bug_report.yml

10e4eea

Create config.yml

cf382a1

Fix Typo in Feature Form

2d51618

Fix Typo in Bug Report

36137ea

Copy link

Author

adityaraute commentedApr 15, 2025

Screenshots:

When you click on New Issue
Bug Report Form
Feature Request Form

Hope you are able to replicate this in your repo

adityaraute marked this pull request as ready for review

April 15, 2025 20:41

adityaraute requested a review frommgol

April 24, 2025 18:05

mgol added the Needs review label

Aug 12, 2025

timmywil changed the title~~Create Feature Request Issue Form~~Docs: Create Bug and Feature Request Issue Form

Oct 13, 2025

timmywil changed the title~~Docs: Create Bug and Feature Request Issue Form~~Create Feature Request Issue Forms

Oct 13, 2025

timmywil changed the title~~Create Feature Request Issue Forms~~Docs: Create Bug and Feature Request Forms

Oct 13, 2025

timmywil reviewed

Oct 13, 2025

View reviewed changes

.github/ISSUE_TEMPLATE/bug_report.yml

		name: Bug Report
		description: Report a bug encountered in JQuery.
		title: "[BUG]: "
		labels: ["bug", "triage"]

Copy link

Member

timmywilOct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think we want these labels.

Copy link

Member

mgolOct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We haveBug (starting with an uppercase letter) in Core, we could add it here as well. The Refined GitHub extension adds a separate tab for issues with such a label.

Agreed abouttriage.

timmywil reviewed

Oct 13, 2025

View reviewed changes

.github/ISSUE_TEMPLATE/Feature Request.yml

		name: Feature Request
		description: Request a feature to be added to JQuery.
		title: "[FEAT]: "
		labels: ["enhancement", "triage"]

Copy link

Member

timmywilOct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No new labels required. We have other labels for this.

Copy link

Member

timmywil commentedOct 13, 2025

Could we remove the existing issue template if/when we add these?
The filenames seem inconsistent:bug_report.yml andFeature Request.yml. I'd like to change the latter tofeature_request.yml.

mgol reviewed

Oct 13, 2025

View reviewed changes

.github/ISSUE_TEMPLATE/bug_report.yml

		@@ -0,0 +1,26 @@
		name: Bug Report

Copy link

Member

mgolOct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's use consistent naming, BTW. This file is namedbug_report.yml, the other one isFeature Request.yml. I'd preferbug-report.yml &feature-request.yml, it'd be more consistent with how we name files.

mgol reviewed

Oct 13, 2025

View reviewed changes

.github/ISSUE_TEMPLATE/bug_report.yml

		id: wiki
		attributes:
		label: Have you checked existing issues?
		description: Before submitting this issue, please check if a similar issue has been raised in the repository [here](https://github.com/jquery/jquery/issues?q=is%3Aissue%20label%3ABug%20).

Copy link

Member

mgolOct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Avoid linking from generic text like "here", it's bad for accessibility:https://granicus.com/blog/why-click-here-links-are-bad/

timmywil removed the Needs review label

Oct 20, 2025

Labels

None yet

Movatterモバイル変換

Docs: Create Bug and Feature Request Forms#5651

Are you sure you want to change the base?

Docs: Create Bug and Feature Request Forms#5651

Uh oh!

Conversation

adityaraute commentedApr 6, 2025

Summary

Checklist

Uh oh!

linux-foundation-easyclabot commentedApr 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

mgol commentedApr 6, 2025

Uh oh!

adityaraute commentedApr 7, 2025

Uh oh!

mgol left a comment

Choose a reason for hiding this comment

Uh oh!

adityaraute commentedApr 15, 2025

Uh oh!

adityaraute commentedApr 15, 2025

Uh oh!

timmywilOct 13, 2025

Choose a reason for hiding this comment

Uh oh!

mgolOct 13, 2025

Choose a reason for hiding this comment

Uh oh!

timmywilOct 13, 2025

Choose a reason for hiding this comment

Uh oh!

timmywil commentedOct 13, 2025

Uh oh!

mgolOct 13, 2025

Choose a reason for hiding this comment

Uh oh!

mgolOct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

linux-foundation-easyclabot commentedApr 6, 2025•
edited
Loading