timmywil left a comment

timmywil left a comment

Also, tweak the Node wrappers & tests a bit without changingthe core of the logic.

The module `node:assert` is deprecated.

We cannot pass a single file via the `module` condition as then`require( "jquery" )` will not return jQuery but instead the module object with`default`, `$` & `jQuery` as keys. Instead:1. For Node.js, detected via the `node` condition:    1. Expose a regular CommonJS version to `require`    2. Expose a tiny wrapper over CommonJS to `import`2. For bundlers, detected via the `module` condition:    1. Expose a regular ESM version to `import`    2. Expose a tiny wrapper over ESM to `require`3. If neither Node.js nor bundlers are detected (no `node` or `module`   conditions`):    1. Expose a regular CommonJS version to `require`    2. Expose a regular ESM version to `import`The reasons for such definitions are as follows:1. In Node.js, one can synchronously import from a CommonJS file inside of   an ESM one but not vice-versa. To use an ESM file in a CommonJS one,   a dynamic import is required and that forces asynchronicity.2. In some bundlers CommonJS is not necessarily enabled - e.g. in Rollup without   the CommonJS plugin. Therefore, the ESM version needs to be pure ESM.   However, bundlers allow synchronously calling `require` on an ESM file. This   is possible since bundlers merge the files before they are passed to   the browser to execute and the final bundles no longer contain async import   code.3. Bare ESM & CommonJS versions are provided to non-Node non-bundler   environments where we cannot assume interoperability between ESM & CommonJS   is supported.4. Bare versions cannot be supplied to Node or bundlers as projects using both   ESM & CommonJS to fetch jQuery would result in duplicate jQuery instances,   leading to increased JS size and disjoint data storage.In addition to the above changes, the `script` condition has been dropped. OnlyWebpack documents this condition and it's not clear when exactly it's triggered.Adding support for a new condition can be added later without a breaking change;removing is not so easy.The `production` & `development` conditions have been removed as well. They werenot really applied correctly; we'd need to provide both of them to each currentleaf which would double the size of the definition for the `.` & `./slim` entrypoints. In jQuery, the only difference between development & production buildsis minification; there are no logic changes so we can pass unminified versionsto all the tooling, expecting minification down the line.Fixesjquerygh-5416

After this commit:1. Node.js always gets the CommonJS version2. Bundlers always get the ESM version3. Other tools take the ESM version when using `import` and the CommonJS when   using `require`.The complexity is lower than for the `.` & `./slim` entry points because there'sno default export to handle so node/bundler wrapper files are not necessary.