- Notifications
You must be signed in to change notification settings - Fork20.6k
Build: add commit SHAs and last runs to comparisons#5329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Delete the sizecache file to reset for accurate comparisons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One remark
Uh oh!
There was an error while loading.Please reload this page.
timmywil commentedSep 20, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Rather than making us manually delete the cache if the format changes, I've added a version number check, which will automatically rewrite the cache on version mismatch. The version number is now saved in the "meta" of the last run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One suggestion. LGTM overall, though.
| sizeCache[ " last run" ] = { | ||
| meta: { version: VERSION }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[Suggestion] It's a bit weird that the version of the whole schema is under the last run key instead of in a globalmeta section. You may consider moving that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I considered it, but last run always gets saved and this is just a little smaller, saving another object. Practically, I think the difference is minimal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, this was just a suggestion, I don't insist. 🙂
Updated tasks include:- lint- npmcopy- build, minify, and process for distribution.- new custom build command using yargs- compare size of minified/gzip built files- pretest scripts, including qunit-fixture, babel transpilation, and npmcopy- node smoke tests- promises aplus tests- new watch task using `rollup.watch` directlyAlso:- upgraded husky and added the new lint command- updated lint config to use new "flat" config format. Seehttps://eslint.org/docs/latest/use/configure/configuration-files-new- Temporarily disabled one lint rule until flat config is supported by eslint-plugin-import. Seeimport-js/eslint-plugin-import#2556- committed package-lock.json- updated all test scripts to use the new build- added an express test server that uses middleware-mockserver (this can be used to run tests without karma)- build-all-variants is now build:allClosegh-5318
Uh oh!
There was an error while loading.Please reload this page.
Fixesgh-5327
Summary
{"branch": {"meta": {"commit":"87de182dada4df850a64f3f062fe656b7d589ed9" },"files": {"dist/jquery.min.js": {"raw":79053,"gz":27701 } } }}" last run". The leading space is intentional to avoid any possible collisions..dirtyis removed for comparisons because we'd like to be able to compare local changes (i.e. dirty git directory") to all branches and last runs that were clean.I can make another PR if preferred, but I tacked on another change here to add the factory files that were just added to the main branch to the dist eslint.
Checklist