- Notifications
You must be signed in to change notification settings - Fork20.6k
Deferred: RenamegetStackHook togetErrorHook#5211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 tasks
mgol added a commit to mgol/jquery that referenced this pull requestFeb 15, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook`to indicate passing an error instance is usually a better choice - itworks with source maps while a raw stack generally does not.In jQuery `3.7.0`, we'll keep both names, marking the old one asdeprecated. In jQuery `4.0.0` we'll just keep the new one. Thischange implements the `3.7.0` version; PRjquerygh-5211 implementsthe `4.0.0` one.Fixesjquerygh-5201Closesjquerygh-5212Refjquerygh-5211
mgol added a commit to mgol/jquery that referenced this pull requestFeb 15, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook`to indicate passing an error instance is usually a better choice - itworks with source maps while a raw stack generally does not.In jQuery `3.7.0`, we'll keep both names, marking the old one asdeprecated. In jQuery `4.0.0` we'll just keep the new one. Thischange implements the `4.0.0` version; PRjquerygh-5212 implementsthe `3.7.0` one.Fixesjquerygh-5201Closesjquerygh-5211Refjquerygh-5212
A few JS Bins to test what gets passed to the hook, justifying the name change:
|
PR to@dmethvin's |
This was referencedFeb 15, 2023
dmethvin approved these changesFeb 24, 2023
dmethvin approved these changesMar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
timmywil approved these changesMar 13, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook`to indicate passing an error instance is usually a better choice - itworks with source maps while a raw stack generally does not.In jQuery `3.7.0`, we'll keep both names, marking the old one asdeprecated. In jQuery `4.0.0` we'll just keep the new one. Thischange implements the `4.0.0` version; PRjquerygh-5212 implementsthe `3.7.0` one.Fixesjquerygh-5201Closesjquerygh-5211Refjquerygh-5212
mgol added a commit to mgol/jquery that referenced this pull requestMar 14, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook`to indicate passing an error instance is usually a better choice - itworks with source maps while a raw stack generally does not.In jQuery `3.7.0`, we'll keep both names, marking the old one asdeprecated. In jQuery `4.0.0` we'll just keep the new one. Thischange implements the `3.7.0` version; PRjquerygh-5211 implementsthe `4.0.0` one.Fixesjquerygh-5201Closesjquerygh-5212Refjquerygh-5211
mgol added a commit that referenced this pull requestMar 14, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook`to indicate passing an error instance is usually a better choice - itworks with source maps while a raw stack generally does not.In jQuery `3.7.0`, we'll keep both names, marking the old one asdeprecated. In jQuery `4.0.0` we'll just keep the new one. Thischange implements the `3.7.0` version; PRgh-5211 implementsthe `4.0.0` one.Fixesgh-5201Closesgh-5212Refgh-5211
This was referencedOct 9, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Rename
jQuery.Deferred.getStackHooktojQuery.Deferred.getErrorHookto indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not.In jQuery
3.7.0, we'll keep both names, marking the old one as deprecated. In jQuery4.0.0we'll just keep the new one. This change implements the4.0.0version; PRgh-5212 implements the3.7.0one.Fixesgh-5201
Refgh-5212
Checklist