Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Core: Drop support for IE (all versions)#5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
mgol wants to merge1 commit intojquery:main
base:main
Choose a base branch
Loading
frommgol:drop-ie-support

Conversation

@mgol
Copy link
Member

@mgolmgol commentedJul 26, 2022
edited
Loading

Summary

This PR is to show what dropping IE support would look like in code. If we make a decision to drop IE in v4, this PR can be merged, guarded on possible review remarks. EDIT: we've decided to land this in5.0.0.

Of course, dropping IE would open a lot of other doors for various refactors but those would be considered separately.

Size difference:

main @65e35450c9954173dc1ddd3576242a913d8efb88   raw     gz     br Filename -1926   -608   -517 dist/jquery.min.js -1720   -550   -556 dist/jquery.slim.min.js -1926   -611   -609 dist-module/jquery.module.min.js -1720   -555   -522 dist-module/jquery.slim.module.min.js

Checklist

kytosai, chrisblakley, silverwind, adanski, boghyon, JarFrank, dnhn, HimanshuGodara, osbre, Julian-B90, and 13 more reacted with thumbs up emojikytosai, chrisblakley, silverwind, pvcresin, dnhn, osbre, bjohansebas, agatemosu, devhaozi, and IRainman reacted with hooray emojikytosai, chrisblakley, GokulPillai98, winston9310, agatemosu, mackieee, and IRainman reacted with heart emojikytosai, dnhn, nicoabie, terremoth, bjohansebas, agatemosu, mackieee, and IRainman reacted with rocket emojikytosai, dnhn, Rudxain, harellevy, agatemosu, mackieee, and IRainman reacted with eyes emoji
Comment on lines -366 to -357
// Support: IE 11+
// ...but not arrow key "clicks" of radio inputs, which can have `button` -1 (gh-2343)
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Firefox doesn't have the behavior from the above comment (click events are not fired for non-primary mouse buttons) so perhaps this all could be removed. But one of our tests checks this condition explicitly so I'd rather leave it for a separate PR.

}elseif(api==="bind"){
$(this).find("input, button, select, textarea").on(type,$cell,blinker);
}else{
$(id+" input,"+id+" button,"+id+" select,"+id+" textarea").live(type,$cell,blinker);
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This file has been broken for a long time due to the use oflive… But it looks potentially useful so I fixed it.

@mgolmgol added Needs review Discuss in MeetingReserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Core labelsJul 27, 2022
@mgolmgol self-assigned thisJul 29, 2022
@dmethvin
Copy link
Member

Seems like the right move at this point. Things clean up nicely!

kytosai and mackieee reacted with rocket emoji

@mgolmgol added this to the5.0.0 milestoneAug 8, 2022
@mgolmgol removed the Discuss in MeetingReserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labelAug 8, 2022
@mgolmgolforce-pushed thedrop-ie-support branch 2 times, most recently from8e858d1 to54f3294CompareApril 6, 2023 10:30
@ollie-iterators
Copy link

The blog about jquery 3.7.0:https://blog.jquery.com/2023/05/11/jquery-3-7-0-released-staying-in-order/ says that "support for IE will be dropped in jQuery 4.0"

@mgol
Copy link
MemberAuthor

@ollie-iterators Thanks for the info; that should say 5.0; we’ll fix it.

mackieee reacted with thumbs up emoji

@vrubleg
Copy link

It's 2023, IE11 is 10 years old, half of the web already doesn't work in this browser. IE11 was introduced with Windows 8.1 that is already not supported by a lot of software (including Firefox and Chrome) and libraries (like Qt6+ or Python 3.9+). It makes sense to drop IE earlier.

Rudxain, tomByrer, gabrielrbarbosa, Porrapat, hduerkop, and IRainman reacted with thumbs up emojiRudxain reacted with eyes emoji

@mgol
Copy link
MemberAuthor

mgol commentedSep 6, 2023

@vrubleg I understand the sentiment and I admit more than a year has passes since I raised this PR but I really don't want to make any changes to our 4.0.0 plans at this point as any further change is just going to delay the whole thing, and it's already been delayed a lot.

I want to get the beta out with only our current blockers resolved. Once we have that, once we also have the respective Migrate release and the upgrade guide prepared, we can talk about it once again.

vrubleg, Rudxain, and terremoth reacted with thumbs up emoji

@mgolmgolforce-pushed thedrop-ie-support branch 3 times, most recently from173239b tob3e684aCompareSeptember 20, 2023 20:25
@nagyimre1980
Copy link

IE drop 4.1.0 ?

hduerkop reacted with thumbs up emoji

@mgol
Copy link
MemberAuthor

@nagyimre1980 No; we treat reducing browser support policy as a breaking change so it has to land in a major version update.

crutchcorn and tuxayo reacted with thumbs up emoji

@mgolmgolforce-pushed thedrop-ie-support branch 2 times, most recently from36ed210 toa35b89dCompareSeptember 21, 2023 23:45
@mgolmgolforce-pushed thedrop-ie-support branch 3 times, most recently from21d7938 to088ce96CompareNovember 20, 2023 13:40
@mgolmgolforce-pushed thedrop-ie-support branch 2 times, most recently fromb74888f toa76a48bCompareMarch 20, 2024 00:28
@mgolmgolforce-pushed thedrop-ie-support branch 2 times, most recently from356bdd0 to5222e6aCompareMay 10, 2024 21:05
@mgolmgolforce-pushed thedrop-ie-support branch 2 times, most recently from630c5cb to6660f03CompareSeptember 16, 2024 21:23
@mgolmgolforce-pushed thedrop-ie-support branch 3 times, most recently from7bd57c0 toebcbd3bCompareJanuary 30, 2025 09:43
@mgolmgol removed the request for review fromdmethvinMarch 3, 2025 22:36
@vrubleg

This comment was marked as off-topic.

@mgol

This comment was marked as off-topic.

@IRainman
Copy link

Why only in 5.0? WebView on Windows 7 is much more functional and convenient and also too outdated as IE11… IE11 isn't legacy; it's dead completely. You can use many improvements in code generation with let and const as basic features, and many more if we drop support for IE completely.

Frulfump reacted with thumbs up emoji

@IRainman
Copy link

By removing IE support, you also remove many crutches and difficult logic that aren't needed in the modern browsers.

Frulfump reacted with thumbs up emoji

@IRainman
Copy link

Furthermore, please checkthis — IE isn't used at all.

Frulfump reacted with thumbs up emoji

@IRainman
Copy link

IRainman commentedSep 26, 2025
edited
Loading

Moreover,Firefox ESR 115 still supports Windows 7 and plans to support it until 2026. You can completely remove support for IE without any issues.

We decided toextend support for ESR 115 only on Windows 7-8.1 and macOS 10.12-10.14 up to March 2026.
We will re-evaluate this decision in February 2026 and announce any updates on ESR 115's end-of-life then.

Frulfump reacted with thumbs up emoji

@nagyimre1980
Copy link

nagyimre1980 commentedSep 26, 2025
edited
Loading

Agree. IE11 has been dead for years! Considering the current release pace, in my opinion, 5.0 will take at least 4-5 years to appear!My main issue: Speed: It would be noticeably faster if we removed all those IE11 branches!The final release of 4.0 is still many months away (I don't think it'll even come out this year)

IRainman, mkurz, and Frulfump reacted with thumbs up emojiIRainman reacted with heart emojiIRainman reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@timmywiltimmywilAwaiting requested review from timmywil

@gibson042gibson042Awaiting requested review from gibson042

1 more reviewer

@IRainmanIRainmanIRainman left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@mgolmgol

Labels

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mgol@dmethvin@ollie-iterators@vrubleg@nagyimre1980@IRainman

[8]ページ先頭

©2009-2025 Movatter.jp