- Notifications
You must be signed in to change notification settings - Fork20.6k
Core: Drop support for IE (all versions)#5077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| // Support: IE 11+ | ||
| // ...but not arrow key "clicks" of radio inputs, which can have `button` -1 (gh-2343) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Firefox doesn't have the behavior from the above comment (click events are not fired for non-primary mouse buttons) so perhaps this all could be removed. But one of our tests checks this condition explicitly so I'd rather leave it for a separate PR.
Uh oh!
There was an error while loading.Please reload this page.
test/delegatetest.html Outdated
| } else { | ||
| $(id+" input,"+id+" button,"+id+" select,"+id+" textarea").live(type, $cell, blinker); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This file has been broken for a long time due to the use oflive… But it looks potentially useful so I fixed it.
Seems like the right move at this point. Things clean up nicely! |
8e858d1 to54f3294Compareollie-iterators commentedMay 12, 2023
The blog about jquery 3.7.0:https://blog.jquery.com/2023/05/11/jquery-3-7-0-released-staying-in-order/ says that "support for IE will be dropped in jQuery 4.0" |
@ollie-iterators Thanks for the info; that should say 5.0; we’ll fix it. |
65f8165 to469a9b2Comparevrubleg commentedAug 27, 2023
It's 2023, IE11 is 10 years old, half of the web already doesn't work in this browser. IE11 was introduced with Windows 8.1 that is already not supported by a lot of software (including Firefox and Chrome) and libraries (like Qt6+ or Python 3.9+). It makes sense to drop IE earlier. |
@vrubleg I understand the sentiment and I admit more than a year has passes since I raised this PR but I really don't want to make any changes to our 4.0.0 plans at this point as any further change is just going to delay the whole thing, and it's already been delayed a lot. I want to get the beta out with only our current blockers resolved. Once we have that, once we also have the respective Migrate release and the upgrade guide prepared, we can talk about it once again. |
173239b tob3e684aComparenagyimre1980 commentedSep 21, 2023
IE drop 4.1.0 ? |
@nagyimre1980 No; we treat reducing browser support policy as a breaking change so it has to land in a major version update. |
36ed210 toa35b89dCompare21d7938 to088ce96Compareb74888f toa76a48bCompare356bdd0 to5222e6aCompare630c5cb to6660f03Compare7bd57c0 toebcbd3bCompare
Uh oh!
There was an error while loading.Please reload this page.
Summary
This PR is to show what dropping IE support would look like in code. If we make a decision to drop IE in v4, this PR can be merged, guarded on possible review remarks.EDIT: we've decided to land this in5.0.0.Of course, dropping IE would open a lot of other doors for various refactors but those would be considered separately.
Size difference:
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com