- Notifications
You must be signed in to change notification settings - Fork20.6k
Docs: Replace#NUMBER Trac issue references withtrac-NUMBER#4993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.A new entry describing issue reference conventions has been added to README.
timmywil approved these changesJan 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I hope this wasn't too tedious. Thanks!
Mansalol approved these changesJan 3, 2022
mgol added a commit to mgol/jquery that referenced this pull requestJan 4, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.A new entry describing issue reference conventions has been added to README.Closesjquerygh-4993Ref5d5ea01
mgol added a commit to mgol/jquery that referenced this pull requestJan 4, 2022
This is a version ofjquerygh-4993 for the `3.x-stable` branch.The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.A new entry describing issue reference conventions has been added to README.Refjquerygh-4993Ref5d5ea01
1 task
@Mansalol Don’t spam our repo with random unrelated comments. This just wastes everyone’s time. |
mgol added a commit to mgol/jquery that referenced this pull requestJan 4, 2022
This is a version ofjquerygh-4993 for the `3.x-stable` branch.The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.A new entry describing issue reference conventions has been added to README.Refjquerygh-4993Ref5d5ea01
mgol added a commit to mgol/jquery that referenced this pull requestJan 4, 2022
PRjquerygh-4993 changed a few too many issue references to `trac-NUMBER` ones. Thischange fixes them. It also fixes a typo in one Trac issue number in selectortests.Refjquerygh-4993
1 task
mgol added a commit that referenced this pull requestJan 12, 2022
This is a version ofgh-4993 for the `3.x-stable` branch.The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.A new entry describing issue reference conventions has been added to README.Closesgh-4994Refgh-4993Ref5d5ea01
mgol added a commit to mgol/jquery that referenced this pull requestSep 8, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.Refjquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull requestSep 12, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.Refjquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull requestSep 19, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.Refjquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull requestSep 21, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.Refjquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull requestOct 3, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.Refjquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull requestOct 4, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.Refjquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull requestNov 17, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.Refjquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull requestDec 1, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.Refjquerygh-4993
mgol added a commit to mgol/jquery that referenced this pull requestDec 13, 2022
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instanceathttps://bugs.jquery.com. This change replaces all such Trac references with`trac-NUMBER`.A few of the references came with the Sizzle integration and referred to theSizzle GitHub bug tracker. Those have been replaced with full links instead.Refjquerygh-4993
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
The GitHub UI treats
#NUMBERas referring to its own issues which is confusingwhen in jQuery source it's usually referring to the old deprecated Trac instance
athttps://bugs.jquery.com. This change replaces all such Trac references with
trac-NUMBER.A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.
A new entry describing issue reference conventions has been added to README.
When this gets accepted, I'll submit a similar PR against the
3.x-stablebranch to keep them aligned.Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com