- Notifications
You must be signed in to change notification settings - Fork20.5k
Docs: Remove links to Web Archive from source#4991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f9233cf toc8fa248Comparetimmywil approved these changesJan 3, 2022
sileclercq commentedJan 4, 2022
any idea when this fix will get in ? which version is this expected to be on ? is there a way to get a 3.6.1 with just this change ? |
Neither of the removed links is crucial; one of them refers to a site that hassince started being malicious; while the Web Archive links remain safe, somescanners warn about such links. Removing them is the safest thing to do.Fixesjquerygh-4981
c8fa248 toec5d22aCompareMemberAuthor
mgol commentedJan 4, 2022
MemberAuthor
mgol commentedJan 4, 2022
@sileclercq It will be included in jQuery 3.6.1 as can be seen by looking at the Milestone field. We don't plan any special release just with this patch as this is not an actual vulnerability. |
timmywil added a commit to timmywil/jquery that referenced this pull requestJan 6, 2022
3 tasks
timmywil added a commit to timmywil/jquery that referenced this pull requestJan 7, 2022
3 tasks
timmywil added a commit that referenced this pull requestJan 7, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Neither of the removed links is crucial; one of them refers to a site that has
since started being malicious; while the Web Archive links remain safe, some
scanners warn about such links. Removing them is the safest thing to do.
Fixesgh-4981
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com