Firefox incorrectly (or perhaps correctly) includes table borders in computed
dimensions, but they are the only one. Workaround this by testing for it and
falling back to offset properties.

This applies to latest FF and so needs to go on master as well.

Checklist

All authors have signed the CLA athttps://cla.js.foundation/jquery/jquery
New tests have been added to show the fix or feature works
Grunt build and unit tests pass locally with these changes
If needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com

+203 bytes

Dimensions: Add offset prop fallback to FF for unreliable TR dimensions

b1da923

Firefox incorrectly (or perhaps correctly) includes table borders in computeddimensions, but they are the only one. Workaround this by testing for it andfalling back to offset propertiesFixesjquerygh-4529

mgol reviewed

Nov 10, 2020

View reviewed changes

Copy link

Member

mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Support tests are coming back! Logic looks good to me, I just hope we can limit the size increase a bit. Some of it is expected, modifying an existing test is cheaper than creating a new one when there's none at the moment.

I added some comments.

src/css.jsShow resolvedHide resolved

src/css/support.jsShow resolvedHide resolved

src/css/support.js OutdatedShow resolvedHide resolved

mgol added Dimensions Discuss in MeetingReserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels

Nov 10, 2020

mgol added this to the4.0.0 milestone

Nov 10, 2020

fixup! use assignment to add support test; add support comment

b48f104

mgol approved these changes

Nov 16, 2020

View reviewed changes

Copy link

Member

mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, just one doubt about a comment. Thanks! 🙂

src/css.js

Comment on lines +149 to +154

		// Support: IE 10 - 11+
		// IE misreports `getComputedStyle` of table rows with width/height
		// set in CSS while `offset*` properties report correct values.
		// Support: Firefox 70+
		// Firefox includes border widths
		// in computed dimensions for table rows. (gh-4529)

Copy link

Member

mgolNov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Back when we had lots of support comment, when code was guarded by one, we usually didn't comment what gets worked around as the support comment above the support test was explaining that anyway. Maybe we can remove this comment in that case here.