NotificationsYou must be signed in to change notification settings
Fork20.6k
Star59.5k

Tests: Workaround failures in recent XSS tests in iOS 8 - 12#4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mgol merged 1 commit intojquery:masterfrommgol:manip-security-tests-ios-fix

Apr 30, 2020

Merged

Tests: Workaround failures in recent XSS tests in iOS 8 - 12#4694

mgol merged 1 commit intojquery:masterfrommgol:manip-security-tests-ios-fix

Apr 30, 2020

Conversation

Copy link

Member

mgol commentedApr 29, 2020

Summary

iOS 8-12 parses<noembed> tags differently, executing this code. This is no
different to native behavior on that OS, though, so just accept it.

Refgh-4685

Checklist

All authors have signed the CLA athttps://cla.js.foundation/jquery/jquery
~~New tests have been added to show the fix or feature works~~
Grunt build and unit tests pass locally with these changes
~~If needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com~~

Tests: Workaround failures in recent XSS tests in iOS 8 - 12

03d34a5

iOS 8-12 parses `<noembed>` tags differently, executing this code. This is nodifferent to native behavior on that OS, though, so just accept it.Refjquerygh-4685

mgol added Needs review Tests Discuss in MeetingReserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels

Apr 29, 2020

mgol added this to the3.5.1 milestone

Apr 29, 2020

mgol self-assigned this

Apr 29, 2020

mgol mentioned this pull request

Apr 29, 2020

Tests: Add tests for recently fixed manipulation XSS issues#4685

Merged

3 tasks

mgol requested review fromgibson042 andtimmywil

April 29, 2020 15:08

Copy link

MemberAuthor

mgol commentedApr 29, 2020

Test runs showing the failure:
http://swarm.jquery.org/job/9718 (master)
http://swarm.jquery.org/job/9719 (3.x-stable)

gibson042 approved these changes

Apr 29, 2020

View reviewed changes

mgol removed Discuss in Meeting

Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting.

Needs review labels

Apr 30, 2020

mgol merged commit11066a9 intojquery:master

Apr 30, 2020

mgol deleted the manip-security-tests-ios-fix branch

April 30, 2020 19:25

mgol added a commit that referenced this pull request

Apr 30, 2020

Tests: Workaround failures in recent XSS tests in iOS 8 - 12

ea2d0d5

iOS 8-12 parses `<noembed>` tags differently, executing this code. This is nodifferent to native behavior on that OS, though, so just accept it.Refgh-4685Closesgh-4694(cherry picked from commit11066a9)