- Notifications
You must be signed in to change notification settings - Fork20.6k
Build: Append .eslintignore paths to grunt eslint paths#4689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This allows us to turn off the `quiet` option which was suppressing warnings.We can also set `maxWarnings` to 0 now that aren't any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I need to test it locally but it looks like a great idea, thanks!
My only worry is ESLint 7 will introduce a newESLint class that will have async methods, deprecating the currentCLIEngine so we'll need to think what to do in such a case:
https://eslint.org/blog/2020/02/whats-coming-in-eslint-7.0.0
I suppose if it gets dropped in ESLint 8 the grunt task can be made async. |
(or at that point just drop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ESLint 7 is out and it still supports theCLIEngine. Looks good to me!
Landed, thanks! |
Summary
This allows us to turn off the
quietoption which was suppressing warnings.We can also set
maxWarningsto 0 now that aren't any, which will catchreportUnusedDisableDirectiveswarnings.Checklist