It would be nice to reduce this forced one-second frequency... what would you think about something like so?

div.appendTo(container);div.html(htmlString);container.append("<img src=x onerror=\"xssDone(counter)\">")

I'll try that, thanks!

@gibson042 Now that I think about it... How do we know thisonerror callback will be fired as the last one? 404 responses may not be cached AFAIK so there's a risk that one will fire before the other ones are done.

Well,src="#" would guarantee that the invalid source is cached.

That will resolve to the current page, though, so it won't be a 404.

Also, currently all the tests succeed even if cache is disabled in the browser DevTools. I'd like to keep that working.

@gibson042 I'm thinking about ways to reduce this delay but if I don't find anything reliable that'd work with cache disabled, I think I'll just merge it, we can always apply improvements later.

We don't need a 404, just need a response that isn't a successful image. And I don't see any cache concerns, but if you want to merge without the acceleration then I won't object.

Good point about not needing 404s. I tested your suggestion, though, and - if I understood it correctly - it looks like I was right about race conditions. See the code at:
mgol@7cd593f
I reverted the two security fixes locally & all assertions should fail but it's pretty random for me; on each refresh different ones are failing for me. I tried theesmodules tests.

An example test run below, I only run this single test. Note that the order of reported assertions is also pretty random.

Yeah, raciness confirmed. I don't think that's fatal to the testing, but it would require restructuring. No worries.