- Notifications
You must be signed in to change notification settings - Fork20.6k
Build: Create agrunt custom:slim alias for the Slim build#4578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mgol commentedDec 31, 2019
| // Replace "slim" with respective exclusions meant for | ||
| // the official slim build | ||
| .reduce( ( acc, elem ) => acc.concat( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
flatMap would be so useful here... Alas, it's Node 12+ and we'll have to support at least v10 for the time being.
timmywil approved these changesJan 7, 2020
gaohuia pushed a commit to gaohuia/jquery that referenced this pull requestJan 9, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a custom
slimalias for the official Slim build. It will allow to achieve the same build locally in an easier way and will also de-duplicate the slim build configuration in changes like#4577, making us sure we really test the slim build even after its definition changes.This PR interferes with#4577 so whichever one lands first, the other one will need to get updated (e.g. if#4577 lands first, this PR will need to modify the new Travis config to use the new alias).
Checklist
If needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com