- Notifications
You must be signed in to change notification settings - Fork20.6k
Build:Tests: Fix custom build tests, verify on Travis#4577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 tasks
bca6bd7 toef1578fComparetimmywil requested changesJan 7, 2020
Uh oh!
There was an error while loading.Please reload this page.
timmywil approved these changesJan 7, 2020
…fects` build (i.e. the 4.x slim build)
2 tasks
Changing milestones, I'll submit a separate PR for the |
gaohuia pushed a commit to gaohuia/jquery that referenced this pull requestJan 9, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The future (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Closesjquerygh-4577
mgol added a commit to mgol/jquery that referenced this pull requestJan 21, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to seeat a glance that a particular job is running on Firefox ESR, for example.Refjquerygh-4577Refjquerygh-4596
mgol added a commit to mgol/jquery that referenced this pull requestJan 21, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to seeat a glance that a particular job is running on Firefox ESR, for example.Refjquerygh-4577Refjquerygh-4596
mgol added a commit to mgol/jquery that referenced this pull requestJan 21, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to seeat a glance that a particular job is running on Firefox ESR, for example.Refjquerygh-4577Refjquerygh-4596
3 tasks
PR to |
mgol added a commit that referenced this pull requestJan 27, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The 4.0 (#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to seeat a glance that a particular job is running on Firefox ESR, for example.Refgh-4577Refgh-4596Closesgh-4600
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes unit tests for the following builds:
custom:-deprecatedcustom:-ajax,-effectscustom:-ajax,-callbacks,-deferred,-effectsIt also adds separate Karma runs for the no-deprecated & current slim builds. Once the new slim build configuration lands, we'll have to modify what we test on Travis as well.
This PR can also be cherry-picked to
3.x-stable.Checklist
If needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com