- Notifications
You must be signed in to change notification settings - Fork20.6k
Core: Exclude callbacks & deferred modules in the slim build as well#4553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f0f980d to4112512CompareSGTM |
We discussed it during the meeting. We'd like to first unbreak current jQuery slim tests on |
4112512 toe7ed773Comparee7ed773 to5770817Compare3 tasks
mgol added a commit that referenced this pull requestJan 7, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The future (#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Closesgh-4577
5770817 to802a984Compare802a984 toccdc1ccComparegaohuia pushed a commit to gaohuia/jquery that referenced this pull requestJan 9, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The future (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Closesjquerygh-4577
So far, the slim build only excluded ajax & effects modules. As many web appsright now rely on native Promises, often with a polyfill for legacy browsers,deferred & callbacks modules are not that useful for sites that already excludeajax & effects modules.This decreases the gzipped minified size of the slim module by 1758 bytes,to 19656 bytes (below 20k!).
ccdc1cc to1c160bbComparetimmywil approved these changesJan 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like it passes slim tests. 👍 from me.
Dave gave his approval before & we discussed this change a while back, it was just on hold until tests for the slim build are added. Therefore, I'm going to merge it now. |
mgol added a commit to mgol/jquery that referenced this pull requestJan 21, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to seeat a glance that a particular job is running on Firefox ESR, for example.Refjquerygh-4577Refjquerygh-4596
mgol added a commit to mgol/jquery that referenced this pull requestJan 21, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to seeat a glance that a particular job is running on Firefox ESR, for example.Refjquerygh-4577Refjquerygh-4596
mgol added a commit to mgol/jquery that referenced this pull requestJan 21, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to seeat a glance that a particular job is running on Firefox ESR, for example.Refjquerygh-4577Refjquerygh-4596
3 tasks
mgol added a commit that referenced this pull requestJan 27, 2020
This commit fixes unit tests for the following builds:1. The no-deprecated build: `custom:-deprecated`2. The current slim build: `custom:-ajax,-effects`3. The 4.0 (#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`It also adds separate Travis jobs for the no-deprecated & slim builds.Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to seeat a glance that a particular job is running on Firefox ESR, for example.Refgh-4577Refgh-4596Closesgh-4600
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
So far, the slim build only excluded ajax & effects modules. As many web apps
right now rely on native Promises, often with a polyfill for legacy browsers,
deferred & callbacks modules are not that useful for sites that already exclude
ajax & effects modules.
This decreases the gzipped minified size of the slim module by 1760 bytes,
to 19706 bytes (below 20k!).
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com