- Notifications
You must be signed in to change notification settings - Fork20.5k
Core: Migrate from AMD to ES modules 🎉#4541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
20 commits Select commitHold shift + click to select a range
7993682 Core: Migrate all source AMD modules to ECMAScript modules
mgol11bc60a Core: Use explicit extensions for imports so that they work natively
mgol8cd544d Core: Make noGlobal handling in global.js work in ES modules mode
mgolc90d8a1 Ajax: Workaround nonce being immutable as an ES module
mgolfa6878b Build: Add a basic Rollup config
mgola72e591 Build: Remove an export from src/queue/delay.js
mgol82cb929 Build: Make sure the jQuery global isn't set when ES modules are used
mgold68ad3c Tests: Convert test setup to work with source ES modules
mgole0e5bff Build: A basic fully working Rollup build (`grunt` & `npm test` both …
mgol9dc310e Build: Normalize srcFolder, fix rollupHypotheticalOptions usage
mgol7fe6f83 Core: disable the max-len rule for the version variable
mgolc6b75df Build: Add back support for custom compilation
mgol1065fa3 Core: Import "./core/parseHTML.js" directly in jquery.js
mgola4250b2 Core: Minor comments tweaks
mgolafeb0eb Build: rename jsmodules to esmodules
mgol3b21968 Build: Use more of Rollup API, simplify logic
mgolf6f0545 Build: Simplify ESLint exclusions & globals, revert globalJQuery to n…
mgol910d815 Build: Move the parseHTML import to save size
mgolc2d5407 Build: Compress ajax/var/nonce.js
mgoleba151a Build: ESLint tweaks
mgolFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Build: Simplify ESLint exclusions & globals, revert globalJQuery to n…
…oGlobal
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitf6f05459e1dd6afdaaf5cf8d62f43febd062b143
There are no files selected for viewing
1 change: 0 additions & 1 deletionbuild/tasks/build.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletionsdist/.eslintrc.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -11,5 +11,9 @@ | ||
| "rules": { | ||
| // That is okay for the built version | ||
| "no-multiple-empty-lines": "off" | ||
| }, | ||
| "globals": { | ||
| "Symbol": false | ||
| } | ||
| } | ||
16 changes: 15 additions & 1 deletionsrc/.eslintrc.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletionssrc/core.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,3 @@ | ||
| import arr from "./var/arr.js"; | ||
| import getProto from "./var/getProto.js"; | ||
| import slice from "./var/slice.js"; | ||
2 changes: 1 addition & 1 deletionsrc/exports/global.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9 changes: 4 additions & 5 deletionssrc/wrapper.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.