- Notifications
You must be signed in to change notification settings - Fork20.6k
Selector: reduce size, simplify setDocument#4462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
|
fd30507 to321f3fbCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Checked this locally and it looks good. Thechrome-debug task was broken, but I'll have a PR to fix it.
With new selector code doing less convoluted support tests, it was possibleto extract a lot of logic out of setDocument & also reduce size.This commit also backportsjquery/sizzle#439 that was reverted by mistakeduring a switch from JSHint + JSCS to ESLint.Refjquery/sizzle#442Refjquery/sizzle#439
Summary
With new selector code doing less convoluted support tests, it was possible
to extract a lot of logic out of setDocument & also reduce size.
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com