NotificationsYou must be signed in to change notification settings
Fork20.6k
Star59.5k

Core: Remove deprecated jQuery APIs#4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mgol merged 1 commit intojquery:masterfrommgol:deprecated-removal

Apr 29, 2019

Merged

Core: Remove deprecated jQuery APIs#4364

mgol merged 1 commit intojquery:masterfrommgol:deprecated-removal

Apr 29, 2019

Conversation

Copy link

Member

mgol commentedApr 17, 2019•
edited by timmywil
Loading

Summary

Fixesgh-4056

Checklist

All authors have signed the CLA athttps://cla.js.foundation/jquery/jquery
~~New tests have been added to show the fix or feature works~~
Grunt build and unit tests pass locally with these changes
If needed, a docs issue/PR was created athttps://github.com/jquery/api.jquery.com

mgol added Needs review Behavior Change Core labels

Apr 17, 2019

mgol mentioned this pull request

Apr 17, 2019

Remove deprecated methods in 4.0.0#4056

Closed

2 tasks

mgol added this to the4.0.0 milestone

Apr 17, 2019

mgol commented

Apr 17, 2019

View reviewed changes

test/unit/css.js

		@@ -1753,9 +1729,6 @@ QUnit.test( "Do not throw on frame elements from css method (#15098)", function(

		assert.expect( !!appearanceName + !!transformName + 1 );

		resetCssPropsFor( "appearance" );
		resetCssPropsFor( "transform" );

Copy link

MemberAuthor

mgolApr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This does make the test a little less isolated but it's already been that way sincefinalPropName has been refactored by@dmethvin to use an internalvendorProps map so we're not losing much here.

Another test can influence this one if it sets some transform- or appearance-related props. We can think if there's any way around that but, as I said, it's already an issue.