Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Event: Stop shimming focusin & focusout events#4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mgol merged 1 commit intojquery:masterfrommgol:focusin-patch
Apr 29, 2019

Conversation

mgol
Copy link
Member

@mgolmgol commentedApr 17, 2019•
edited
Loading

Summary

Latest versions of all browsers now implement focusin & focusout natively
and they all converged on a common event order so it doesn't make much sense
for us to normalize it to a different order anymore.

Note that it means we no longer guarantee that focusin fires before focus
and focusout before blur.

-123 bytes

Fixesgh-4300

Checklist

@mgol
Copy link
MemberAuthor

mgol commentedApr 17, 2019•
edited
Loading

Note: this cannot go in as long as we test on Firefox 60 which doesn't supportfocusin &focusout. If we decide to drop this browser as part of#4347 (which I recommend) then this can land.

EDIT: I mixed up the version, this has been implemented since Firefox 52 so we're good to go.

@mgolmgol self-assigned thisApr 17, 2019
Copy link
Member

@dmethvindmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There's a mention in README.md that should be removed as well.

@mgol
Copy link
MemberAuthor

@dmethvin Nice catch! PR updated.

@mgol
Copy link
MemberAuthor

I also added a new test checking iffocusin &focusout work at all. I think we didn't have such test apart from the one checking the order so we'd actually lose some coverage by removing that test without a replacement.

Copy link
Member

@dmethvindmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Latest versions of all browsers now implement focusin & focusout nativelyand they all converged on a common event order so it doesn't make much sensefor us to normalize it to a different order anymore.Note that it means we no longer guarantee that focusin fires before focusand focusout before blur.Fixesjquerygh-4300
@mgolmgol merged commit8a74137 intojquery:masterApr 29, 2019
@mgolmgol deleted the focusin-patch branchApril 29, 2019 19:13
mgol added a commit to mgol/jquery that referenced this pull requestApr 29, 2019
In IE, focus & blur events fire asynchronously, the test now accounts for that.Refjquerygh-4362
@locklockbot locked asresolvedand limited conversation to collaboratorsOct 26, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dmethvindmethvindmethvin approved these changes

@timmywiltimmywiltimmywil approved these changes

@gibson042gibson042gibson042 approved these changes

Assignees

@mgolmgol

Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Stop shimmingfocusin/focusout in jQuery 4.0
4 participants
@mgol@dmethvin@timmywil@gibson042
[8]ページ先頭
©2009-2025 Movatter.jp