Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WIP] Event: Use one native handler per jQuery handler#3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dmethvin wants to merge1 commit intojquery:main
base:main
Choose a base branch
Loading
fromdmethvin:v4-demux-handlers

Conversation

@dmethvin
Copy link
Member

@dmethvindmethvin commentedMay 24, 2016•
edited
Loading

This is definitely a v4 kind of thing with breaking changes and it still needs more work before it passes tests, but I'll post it here in case anyone has thoughts or comments.

EDIT: All my comments from below are in my fork,dmethvin@113ce67

praveenswengineer reacted with laugh emoji
Some tests are still failing, need to fix propagation issues

if(elem.addEventListener){
elem.addEventListener(type,eventHandle);
elem.addEventListener(type,handleObj);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is still guarded by:

if(!(handlers=events[type])){

making it oneaddEventListener per event type... Or am I reading it wrong?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hmm, I'll definitely look into that. Seems like a LOT of stuff should have broken.

@timmywiltimmywil added this to the4.0.0 milestoneJul 13, 2016
@dmethvindmethvin deleted the v4-demux-handlers branchAugust 4, 2016 12:40
@dmethvindmethvin restored the v4-demux-handlers branchAugust 4, 2016 12:40
@mgol
Copy link
Member

@dmethvin was it supposed to get closed? I suppose not as it still has a milestone so I'm reopening it.

@mgolmgol reopened thisOct 10, 2016
@dmethvin
Copy link
MemberAuthor

Looks like I accidentally deleted the fork in August which closed it, so yeah it should still be open.

Base automatically changed frommaster tomainFebruary 1, 2021 22:02
@mgol
Copy link
Member

Closing & re-opening the PR to trigger the EasyCLA check...

@mgolmgol closed thisSep 17, 2021
@mgolmgol reopened thisSep 17, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easyclabot commentedSep 17, 2021•
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@jqueryjquery deleted a comment from22aamJan 25, 2022
@jqueryjquery deleted a comment from22aamJan 26, 2022
@mgolmgol marked this pull request as draftJuly 18, 2022 12:53
@mgolmgol changed the title[WIP] Event: Use one native handler per jQuery handlerEvent: Use one native handler per jQuery handlerJul 18, 2022
@mgolmgol changed the titleEvent: Use one native handler per jQuery handler[WIP] Event: Use one native handler per jQuery handlerJul 18, 2022
@mgolmgol modified the milestones:4.0.0,5.0.0Aug 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dmethvin@mgol@timmywil@jquerybot@JSFOwner
[8]ページ先頭
©2009-2025 Movatter.jp