- Notifications
You must be signed in to change notification settings - Fork20.6k
Build: Remove dates from copyright notice#1983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -137,7 +137,7 @@ module.exports = function( grunt ) { | |||
| "ascii_only": true | |||
| }, | |||
| banner: "/*! jQuery v<%= pkg.version %> | " + | |||
| "(c) 2005, <%= grunt.template.today('yyyy') %>jQuery Foundation, Inc. | " + | |||
| "CopyrightjQuery Foundation and other contributors " + | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why the change from(c) toCopyright? You didn't do the same in the Sizzle PR:https://github.com/jquery/sizzle/pull/307/files
This is the banner put in the minified files, e.g.https://code.jquery.com/jquery-2.1.3.min.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd leave| at the end, it separates the copyright info from the URL to the license (see the linked minified file for example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@mzgol Thanks for the comments. I'll make the changes now.
LGTM |
| @@ -137,7 +137,7 @@ module.exports = function( grunt ) { | |||
| "ascii_only": true | |||
| }, | |||
| banner: "/*! jQuery v<%= pkg.version %> | " + | |||
| "(c)2005, <%= grunt.template.today('yyyy') %>jQuery Foundation, Inc. | " + | |||
| "(c) jQuery Foundation, Inc. | " + | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In the intro file you also dropped theInc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+1, why this is being dropped btw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We don't need them, according to lawyers. So removing the dates makes it easier to maintain! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll remove theInc. here for consistency.
I'm not too sure about the change in Gruntfile.js, so please let me know if you would like it to be different, e,g, whether the jquery.org/license should be on the same line as the Copyright notice, whether it should behttps://jquery.org/ orhttps://jquery.org/license also, or anything else.