Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DroptoggleClass(boolean) andtoggleClass(undefined) signatures #3388

Closed
@silverwind

Description

@silverwind

Can we evaluate if these signatures can be dropped? Here's a few arguments:

  • It can mask bugs when the first argument inadvertently evaluates toundefined, which results in all classes being removed the first time it is called.
  • It's badly documented (Misleading documentation for toggleClass() method. #1696) and because of that, probably not well-known.
  • The way it saves a__className__ data seems like a bad practice.
  • For custom builds, it creates a otherwise unnecessary dependency forattributes/classes towardsdata.
  • It would allow the following savings for full builds:
   raw     gz Compared to master @ 5b4cb0d33731a58384e02ad51e703e7dcb00e424  -701   -230 dist/jquery.js  -168    -61 dist/jquery.min.js

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp