NotificationsYou must be signed in to change notification settings
Fork20.6k
Star59.5k

Commitff75767

timmywil

committed

Minor adjustments and cleanup, including normalizing the value to a string when setting( list of changes below )

- Normalize set value to string to synchronize return type cross-browser- Add style attrHook to propHooks to support style getting in all browsers for both attr and prop- Extend the selected propHook instead of overriding a possible set function- Remove selected propHook TODO since there is no selected content attribute and it should return null

1 parent8cbf551 commitff75767Copy full SHA for ff75767

File tree

1 file changed

-16

lines changed

src
- attributes.js

1 file changed

-16

lines changed

`‎src/attributes.js`

Lines changed: 7 additions & 16 deletions

Original file line number	Diff line number	Diff line change
`@@ -313,7 +313,7 @@ jQuery.extend({`
`313`	`313`	`returnret;`
`314`	`314`
`315`	`315`	`}else{`
`316`		`-elem.setAttribute(name,value);`
	`316`	`+elem.setAttribute(name,""+value);`
`317`	`317`	`returnvalue;`
`318`	`318`	`}`
`319`	`319`
`@@ -440,10 +440,8 @@ if ( !jQuery.support.getSetAttribute ) {`
`440`	`440`	`varret=elem.getAttributeNode(name);`
`441`	`441`	`if(ret){`
`442`	`442`	`ret.nodeValue=value;`
`443`		`-}else{`
`444`		`-elem.setAttribute(name,value);`
	`443`	`+returnvalue;`
`445`	`444`	`}`
`446`		`-returnvalue;`
`447`	`445`	`}`
`448`	`446`	`};`
`449`	`447`	`}`
`@@ -458,9 +456,6 @@ jQuery.each([ "selected", "checked", "readonly", "disabled" ], function( i, name`
`458`	`456`	`jQuery.removeAttr(elem,name);`
`459`	`457`	`returnfalse;`
`460`	`458`	`}`
`461`		`-`
`462`		`-elem.setAttribute(name,value);`
`463`		`-returnvalue;`
`464`	`459`	`}`
`465`	`460`	`});`
`466`	`461`	`});`
`@@ -477,7 +472,7 @@ if ( !jQuery.support.hrefNormalized ) {`
`477`	`472`	`}`
`478`	`473`
`479`	`474`	`if(!jQuery.support.style){`
`480`		`-jQuery.attrHooks.style={`
	`475`	`+jQuery.propHooks.style=jQuery.attrHooks.style={`
`481`	`476`	`get:function(elem){`
`482`	`477`	`returnelem.style.cssText;`
`483`	`478`	`},`
`@@ -490,24 +485,20 @@ if ( !jQuery.support.style ) {`
`490`	`485`	`// Safari mis-reports the default selected property of an option`
`491`	`486`	`// Accessing the parent's selectedIndex property fixes it`
`492`	`487`	`if(!jQuery.support.optSelected){`
`493`		`-`
`494`		`-jQuery.propHooks.selected={`
	`488`	`+jQuery.propHooks.selected=jQuery.extend(jQuery.propHooks.selected,{`
`495`	`489`	`get:function(elem){`
`496`	`490`	`varparent=elem.parentNode;`
`497`		`-`
	`491`	`+`
`498`	`492`	`if(parent){`
`499`	`493`	`parent.selectedIndex;`
`500`		`-`
`501`		`-// TODO: We may need an attrHook for selected that simply defers to prop?`
`502`		`-// The attr is undefined if the option is created with createElement and not on the DOM`
`503`		`-`
	`494`	`+`
`504`	`495`	`// Make sure that it also works with optgroups, see #5701`
`505`	`496`	`if(parent.parentNode){`
`506`	`497`	`parent.parentNode.selectedIndex;`
`507`	`498`	`}`
`508`	`499`	`}`
`509`	`500`	`}`
`510`		`-};`
	`501`	`+});`
`511`	`502`	`}`
`512`	`503`
`513`	`504`	`})(jQuery);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitff75767

File tree

1 file changed

1 file changed

`‎src/attributes.js`

0 commit comments