NotificationsYou must be signed in to change notification settings
Fork20.6k
Star59.5k

Commitccbd6b9

authored

Traversing: Fixcontents() on<object>s with children in IE

The original fix didn't account for the fact that in IE `<object>` elementswith no `data` attribute have an object `contentDocument`. The fix leveragesthe fact that this special object has a null prototype.Closesgh-4390Refgh-4384Refgh-4385

1 parent4d865d9 commitccbd6b9Copy full SHA for ccbd6b9

File tree

1 file changed

-2

lines changed

src
- traversing.js

1 file changed

-2

lines changed

`‎src/traversing.js`

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`define([`
`2`	`2`	`"./core",`
	`3`	`+"./var/getProto",`
`3`	`4`	`"./var/indexOf",`
`4`	`5`	`"./traversing/var/dir",`
`5`	`6`	`"./traversing/var/siblings",`
`@@ -9,7 +10,7 @@ define( [`
`9`	`10`	`"./core/init",`
`10`	`11`	`"./traversing/findFilter",`
`11`	`12`	`"./selector"`
`12`		`-],function(jQuery,indexOf,dir,siblings,rneedsContext,nodeName){`
	`13`	`+],function(jQuery,getProto,indexOf,dir,siblings,rneedsContext,nodeName){`
`13`	`14`
`14`	`15`	`"use strict";`
`15`	`16`
`@@ -145,7 +146,13 @@ jQuery.each( {`
`145`	`146`	`returnsiblings(elem.firstChild);`
`146`	`147`	`},`
`147`	`148`	`contents:function(elem){`
`148`		`-if(elem.contentDocument!=null){`
	`149`	`+if(elem.contentDocument!=null&&`
	`150`	`+`
	`151`	`+// Support: IE 11+`
	`152`	+// <object> elements with no `data` attribute has an object
	`153`	+// `contentDocument` with a `null` prototype.
	`154`	`+getProto(elem.contentDocument)){`
	`155`	`+`
`149`	`156`	`returnelem.contentDocument;`
`150`	`157`	`}`
`151`	`158`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitccbd6b9

File tree

1 file changed

1 file changed

`‎src/traversing.js`

0 commit comments