NotificationsYou must be signed in to change notification settings
Fork20.5k
Star59.7k

Commit50e8e84

authored

Tests: Make more tests run natively in Chrome & Firefox

Chrome & Firefox now support complex `:not()` selectors so those test can runin them even without custom jQuery selector code. In the past, it was onlypossible in Safari, now we only need to exclude IE.Closesgh-4864

1 parent345cd22 commit50e8e84Copy full SHA for 50e8e84

File tree

1 file changed

-9

lines changed

test/unit
- selector.js

1 file changed

-9

lines changed

`‎test/unit/selector.js‎`

Lines changed: 9 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -1137,14 +1137,14 @@ QUnit.test( "pseudo - :not", function( assert ) {`
`1137`	`1137`	`assert.t(":not() failing interior","#qunit-fixture p:not(.foo)",["firstp","ap","sndp","en","sap","first"]);`
`1138`	`1138`	`assert.t(":not() failing interior","#qunit-fixture p:not(#blargh)",["firstp","ap","sndp","en","sap","first"]);`
`1139`	`1139`
`1140`		`-if(QUnit.jQuerySelectors\|\|this.safari){`
	`1140`	`+if(QUnit.jQuerySelectors\|\|!QUnit.isIE){`
`1141`	`1141`	`assert.t(":not() failing interior","#qunit-fixture p:not(div.foo)",["firstp","ap","sndp","en","sap","first"]);`
`1142`	`1142`	`assert.t(":not() failing interior","#qunit-fixture p:not(p.foo)",["firstp","ap","sndp","en","sap","first"]);`
`1143`	`1143`	`assert.t(":not() failing interior","#qunit-fixture p:not(div#blargh)",["firstp","ap","sndp","en","sap","first"]);`
`1144`	`1144`	`assert.t(":not() failing interior","#qunit-fixture p:not(p#blargh)",["firstp","ap","sndp","en","sap","first"]);`
`1145`	`1145`	`}else{`
`1146`		`-// Support:Chrome 75+, Firefox 67+`
`1147`		-//Chrome/Firefox don't support `:not(complex selector)`.
	`1146`	`+// Support:IE 11+`
	`1147`	+//IE doesn't support `:not(complex selector)`.
`1148`	`1148`	`assert.ok("skip",":not(complex selector) not supported in selector-native");`
`1149`	`1149`	`assert.ok("skip",":not(complex selector) not supported in selector-native");`
`1150`	`1150`	`assert.ok("skip",":not(complex selector) not supported in selector-native");`
`@@ -1156,15 +1156,15 @@ QUnit.test( "pseudo - :not", function( assert ) {`
`1156`	`1156`	`assert.t(":not Multiple","#qunit-fixture p:not( p )",[]);`
`1157`	`1157`	`assert.t(":not Multiple","p:not(p)",[]);`
`1158`	`1158`
`1159`		`-if(QUnit.jQuerySelectors\|\|this.safari){`
	`1159`	`+if(QUnit.jQuerySelectors\|\|!QUnit.isIE){`
`1160`	`1160`	`assert.t(":not Multiple","#qunit-fixture p:not(a, b)",["firstp","ap","sndp","en","sap","first"]);`
`1161`	`1161`	`assert.t(":not Multiple","#qunit-fixture p:not(a, b, div)",["firstp","ap","sndp","en","sap","first"]);`
`1162`	`1162`	`assert.t(":not Multiple","p:not(a,p)",[]);`
`1163`	`1163`	`assert.t(":not Multiple","p:not(p,a)",[]);`
`1164`	`1164`	`assert.t(":not Multiple","p:not(a,p,b)",[]);`
`1165`	`1165`	`}else{`
`1166`		`-// Support:Chrome 75+, Firefox 67+`
`1167`		-//Chrome/Firefox don't support `:not(complex selector)`.
	`1166`	`+// Support:IE 11+`
	`1167`	+//IE doesn't support `:not(complex selector)`.
`1168`	`1168`	`assert.ok("skip",":not(complex selector) not supported in selector-native");`
`1169`	`1169`	`assert.ok("skip",":not(complex selector) not supported in selector-native");`
`1170`	`1170`	`assert.ok("skip",":not(complex selector) not supported in selector-native");`
`@@ -1189,11 +1189,11 @@ QUnit.test( "pseudo - :not", function( assert ) {`
`1189`	`1189`	`assert.t(":not() Multiple Class","#foo a:not(.blog)",["yahoo","anchor2"]);`
`1190`	`1190`	`assert.t(":not() Multiple Class","#foo a:not(.link)",["yahoo","anchor2"]);`
`1191`	`1191`
`1192`		`-if(QUnit.jQuerySelectors\|\|this.safari){`
	`1192`	`+if(QUnit.jQuerySelectors\|\|!QUnit.isIE){`
`1193`	`1193`	`assert.t(":not() Multiple Class","#foo a:not(.blog.link)",["yahoo","anchor2"]);`
`1194`	`1194`	`}else{`
`1195`		`-// Support:Chrome 75+, Firefox 67+`
`1196`		-//Chrome/Firefox don't support `:not(complex selector)`.
	`1195`	`+// Support:IE 11+`
	`1196`	+//IE doesn't support `:not(complex selector)`.
`1197`	`1197`	`assert.ok("skip",":not(complex selector) not supported in selector-native");`
`1198`	`1198`	`}`
`1199`	`1199`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit50e8e84

File tree

1 file changed

1 file changed

`‎test/unit/selector.js‎`

0 commit comments