Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit4a7fc85

Browse files
authored
Build: Enable ESLint one-var rule for var declarations in browser code
Node.js code is written more & more commonly in ES6+ so it doesn't make senseto enable it there. There are many violations in test code so it's disabledthere as well.Closesgh-4615
1 parent364476c commit4a7fc85

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

‎.eslintrc-browser.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
},
2020

2121
"rules": {
22+
"one-var": ["error", {"var":"always"}],
2223
"strict": ["error","function"]
2324
}
2425
}

‎dist/.eslintrc.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919

2020
"rules": {
2121
// That is okay for the built version
22-
"no-multiple-empty-lines":"off"
22+
"no-multiple-empty-lines":"off",
23+
"one-var":"off"
2324
}
2425
}
2526
]

‎src/css/support.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ var reliableTrDimensionsVal;
88
// IE/Edge misreport `getComputedStyle` of table rows with width/height
99
// set in CSS while `offset*` properties report correct values.
1010
support.reliableTrDimensions=function(){
11-
vartable,tr,trChild;
11+
vartable,tr,trChild,trStyle;
1212
if(reliableTrDimensionsVal==null){
1313
table=document.createElement("table");
1414
tr=document.createElement("tr");
@@ -23,7 +23,7 @@ support.reliableTrDimensions = function() {
2323
.appendChild(tr)
2424
.appendChild(trChild);
2525

26-
vartrStyle=window.getComputedStyle(tr);
26+
trStyle=window.getComputedStyle(tr);
2727
reliableTrDimensionsVal=parseInt(trStyle.height)>3;
2828

2929
documentElement.removeChild(table);

‎src/event.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -288,11 +288,12 @@ jQuery.event = {
288288

289289
dispatch:function(nativeEvent){
290290

291-
// Make a writable jQuery.Event from the native event object
292-
varevent=jQuery.event.fix(nativeEvent);
293-
294291
vari,j,ret,matched,handleObj,handlerQueue,
295292
args=newArray(arguments.length),
293+
294+
// Make a writable jQuery.Event from the native event object
295+
event=jQuery.event.fix(nativeEvent),
296+
296297
handlers=(dataPriv.get(this,"events")||{})[event.type]||[],
297298
special=jQuery.event.special[event.type]||{};
298299

‎test/.eslintrc.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
"brace-style":"off",
4848
"key-spacing":"off",
4949
"camelcase":"off",
50+
"one-var":"off",
5051
"strict":"off",
5152

5253
// Not really too many - waiting for autofix features for these rules

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp