- Notifications
You must be signed in to change notification settings - Fork20.6k
Commit44ac8c8
authored
Build: Require extensions for ES6 imports, prevent import cycles
jQuery source is now authored in ECMAScript modules. Native browser supportfor them requires full file names including extensions. Rollup works evenif import paths don't specify extensions, though, so one import slippedthrough without such an extension, breaking native browser import ofsrc/jquery.js.A new ESLint rule using eslint-plugin-import prevents us from regressingon that front.Also, eslint-plugin-import's no-cycle rule is used to avoid import cycles.Closesgh-4544Refgh-4541Ref07532011 parent0753201 commit44ac8c8
2 files changed
+8
-0
lines changedLines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
30 | 30 |
| |
31 | 31 |
| |
32 | 32 |
| |
| 33 | + | |
33 | 34 |
| |
34 | 35 |
| |
35 | 36 |
| |
|
Lines changed: 7 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
8 | 8 |
| |
9 | 9 |
| |
10 | 10 |
| |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
11 | 18 |
| |
12 | 19 |
| |
13 | 20 |
| |
|
0 commit comments
Comments
(0)