Commit364476c

authored

Tests: Pass a number of necessary done() calls to assert.async()

It is no longer needed to create `done` wrappers in tests that requiremultiple async operations to complete.Closesgh-4633

1 parent721744a commit364476cCopy full SHA for 364476c

File tree

+10

-10

lines changed

+10

-10

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,14 +4,14 @@ if ( jQuery.ajax ) {`
`4`	`4`	`QUnit.test("ajax",function(assert){`
`5`	`5`	`assert.expect(4);`
`6`	`6`
`7`		`-vardone=jQuery.map(newArray(3),function(){returnassert.async();});`
	`7`	`+vardone=assert.async(3);`
`8`	`8`
`9`	`9`	`jQuery.ajax({`
`10`	`10`	`type:"GET",`
`11`	`11`	`url:url("mock.php?action=name&name=foo"),`
`12`	`12`	`success:function(msg){`
`13`	`13`	`assert.strictEqual(msg,"bar","Check for GET");`
`14`		`-done.pop()();`
	`14`	`+done();`
`15`	`15`	`}`
`16`	`16`	`});`
`17`	`17`
`@@ -21,14 +21,14 @@ QUnit.test( "ajax", function( assert ) {`
`21`	`21`	`data:"name=peter",`
`22`	`22`	`success:function(msg){`
`23`	`23`	`assert.strictEqual(msg,"pan","Check for POST");`
`24`		`-done.pop()();`
	`24`	`+done();`
`25`	`25`	`}`
`26`	`26`	`});`
`27`	`27`
`28`	`28`	`jQuery("#first").load(url("name.html"),function(){`
`29`	`29`	`assert.ok(/^ERROR/.test(jQuery("#first").text()),`
`30`	`30`	`"Check if content was injected into the DOM");`
`31`		`-done.pop()();`
	`31`	`+done();`
`32`	`32`	`});`
`33`	`33`	`});`
`34`	`34`	`}`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -107,31 +107,31 @@ QUnit.module( "ready" );`
`107`	`107`
`108`	`108`	`QUnit[jQuery.when ?"test" :"skip"]("jQuery.when(jQuery.ready)",function(assert){`
`109`	`109`	`assert.expect(2);`
`110`		`-vardone=jQuery.map(newArray(2),function(){returnassert.async();});`
	`110`	`+vardone=assert.async(2);`
`111`	`111`
`112`	`112`	`whenified.then(function(){`
`113`	`113`	`assert.ok(jQuery.isReady,"jQuery.when Deferred resolved");`
`114`		`-done.pop()();`
	`114`	`+done();`
`115`	`115`	`});`
`116`	`116`
`117`	`117`	`jQuery.when(jQuery.ready).then(function(){`
`118`	`118`	`assert.ok(jQuery.isReady,"jQuery.when Deferred resolved");`
`119`		`-done.pop()();`
	`119`	`+done();`
`120`	`120`	`});`
`121`	`121`	`});`
`122`	`122`
`123`	`123`	`QUnit.test("Promise.resolve(jQuery.ready)",function(assert){`
`124`	`124`	`assert.expect(2);`
`125`		`-vardone=jQuery.map(newArray(2),function(){returnassert.async();});`
	`125`	`+vardone=assert.async(2);`
`126`	`126`
`127`	`127`	`promisified.then(function(){`
`128`	`128`	`assert.ok(jQuery.isReady,"Native promised resolved");`
`129`		`-done.pop()();`
	`129`	`+done();`
`130`	`130`	`});`
`131`	`131`
`132`	`132`	`Promise.resolve(jQuery.ready).then(function(){`
`133`	`133`	`assert.ok(jQuery.isReady,"Native promised resolved");`
`134`		`-done.pop()();`
	`134`	`+done();`
`135`	`135`	`});`
`136`	`136`	`});`
`137`	`137`

Comments

(0)