NotificationsYou must be signed in to change notification settings
Fork20.5k
Star59.7k

Commit297d18d

authored

CSS: Includeshow,hide &toggle methods in the jQuery slim build

The `show()`, `hide()` & `toggle()` methods were included in the 3.x jQueryslim build. The jQuery master build accidentally started to exclude them asthey were only imported in the effects module and the new Rollup-based buildsystem follows the module dependency graph when excluding modules.To resolve the issue, import the `css/showHide.js` file directly in the main`jquery.js` file.Closesgh-4704Refjquery/jquery-migrate#346

1 parent3d62d57 commit297d18dCopy full SHA for 297d18d

File tree

2 files changed

-5

lines changed

src
- jquery.js
test/unit
- css.js

2 files changed

-5

lines changed

`‎src/jquery.js‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ import "./manipulation/_evalUrl.js";`
`16`	`16`	`import"./wrap.js";`
`17`	`17`	`import"./css.js";`
`18`	`18`	`import"./css/hiddenVisibleSelectors.js";`
	`19`	`+import"./css/showHide.js";`
`19`	`20`	`import"./serialize.js";`
`20`	`21`	`import"./ajax.js";`
`21`	`22`	`import"./ajax/xhr.js";`

`‎test/unit/css.js‎`

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -487,9 +487,6 @@ QUnit.test( "css(Object) where values are Functions with incoming values", funct`
`487`	`487`	`jQuery("#cssFunctionTest").remove();`
`488`	`488`	`});`
`489`	`489`
`490`		`-// .show(), .hide(), can be excluded from the build`
`491`		`-if(jQuery.fn.show&&jQuery.fn.hide){`
`492`		`-`
`493`	`490`	`QUnit.test("show()",function(assert){`
`494`	`491`
`495`	`492`	`assert.expect(18);`
`@@ -968,8 +965,6 @@ QUnit.test( "show/hide 3.0, inline hidden", function( assert ) {`
`968`	`965`	`});`
`969`	`966`	`});`
`970`	`967`
`971`		`-}`
`972`		`-`
`973`	`968`	`QUnit[QUnit.jQuerySelectors&&jQuery.fn.toggle ?"test" :"skip"]("toggle()",function(assert){`
`974`	`969`	`assert.expect(9);`
`975`	`970`	`vardiv,oldHide,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit297d18d

File tree

2 files changed

2 files changed

`‎src/jquery.js‎`

`‎test/unit/css.js‎`

0 commit comments