Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit1ad66ae

Browse files
authored
Build: Run pretest before test:* npm scripts
Build was already happening in scripts like `test:browser` but those scriptswere missing `pretest`, meaning that running `npm install && npm test:browser`may have failed if `pretest` wasn't run before or if its results were out ofdate.Even worse, with such stale data some tests may erroneously succeed.This also removes a separate `pretest` step from GitHub Actions as it's nolonger needed.Closesgh-5338
1 parentace646f commit1ad66ae

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

‎.github/workflows/node.js.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,6 @@ jobs:
7474
run:npm run build:all && npm run lint
7575
if:matrix.NODE_VERSION == '18.x'
7676

77-
-name:Prepare tests
78-
run:npm run pretest
79-
8077
-name:Run tests
8178
env:
8279
BROWSERS:${{ matrix.BROWSERS }}

‎package.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,14 @@
5252
"pretest":"npm run qunit-fixture && npm run babel:tests && npm run npmcopy",
5353
"qunit-fixture":"node build/tasks/qunit-fixture.js",
5454
"start":"node -e\"require('./build/tasks/build.js').buildDefaultFiles({ watch: true })\"",
55-
"test:browserless":"npm run test:node_smoke_tests && npm run test:promises_aplus && npm run test:jsdom",
56-
"test:browser":"npm run build:all && grunt karma:main",
57-
"test:esmodules":"npm run build:main && grunt karma:esmodules",
58-
"test:jsdom":"npm run build:main && grunt test:jsdom",
59-
"test:no-deprecated":"npm run build -- -e deprecated && grunt karma:main",
60-
"test:selector-native":"npm run build -- -e selector && grunt karma:main",
61-
"test:slim":"npm run build -- --slim && grunt karma:main",
62-
"test:node_smoke_tests":"npm run build:all && node build/tasks/node_smoke_tests.js",
55+
"test:browserless":"npm runpretest && npm runtest:node_smoke_tests && npm run test:promises_aplus && npm run test:jsdom",
56+
"test:browser":"npm runpretest && npm runbuild:all && grunt karma:main",
57+
"test:esmodules":"npm runpretest && npm runbuild:main && grunt karma:esmodules",
58+
"test:jsdom":"npm runpretest && npm runbuild:main && grunt test:jsdom",
59+
"test:no-deprecated":"npm runpretest && npm runbuild -- -e deprecated && grunt karma:main",
60+
"test:selector-native":"npm runpretest && npm runbuild -- -e selector && grunt karma:main",
61+
"test:slim":"npm runpretest && npm runbuild -- --slim && grunt karma:main",
62+
"test:node_smoke_tests":"npm runpretest && npm runbuild:all && node build/tasks/node_smoke_tests.js",
6363
"test:promises_aplus":"npm run build:main && node build/tasks/promises_aplus_tests.js",
6464
"test":"npm run build:all && npm run lint && npm run test:browserless && npm run test:browser && npm run test:esmodules && npm run test:slim && npm run test:no-deprecated && npm run test:selector-native"
6565
},

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp