NotificationsYou must be signed in to change notification settings
Fork20.6k
Star59.5k

Commit0b9c503

authored

Deferred: Respect source maps in jQuery.Deferred.exceptionHook

So far, `jQuery.Deferred.exceptionHook` used to log error message and stackseparately. However, that breaks browser applying source maps against the stacktrace - most browsers require logging an error instance. This change makes usdo exactly that.One drawback of the change is that in IE 11 previously stack was printeddirectly and now just the error summary; to get to the actual stacktrace, three clicks are required. This seems to be a low price to payfor having source maps work in all the other browsers, though.Safari with the new change requires one click to get to the stack tracewhich sounds manageable.Fixesgh-3179Closesgh-5192Refhttps://crbug.com/622227

1 parent6d13644 commit0b9c503Copy full SHA for 0b9c503

File tree

2 files changed

-5

lines changed

src/deferred
- exceptionHook.js
test/unit
- deferred.js

2 files changed

-5

lines changed

`‎src/deferred/exceptionHook.js`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,8 @@ jQuery.Deferred.exceptionHook = function( error, stack ) {`
`10`	`10`
`11`	`11`	`if(error&&rerrorNames.test(error.name)){`
`12`	`12`	`window.console.warn(`
`13`		`-"jQuery.Deferred exception: "+error.message,`
`14`		`-error.stack,`
	`13`	`+"jQuery.Deferred exception",`
	`14`	`+error,`
`15`	`15`	`stack`
`16`	`16`	`);`
`17`	`17`	`}`

`‎test/unit/deferred.js`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -575,9 +575,9 @@ QUnit.test( "jQuery.Deferred.exceptionHook", function( assert ) {`
`575`	`575`	`defer=jQuery.Deferred(),`
`576`	`576`	`oldWarn=window.console.warn;`
`577`	`577`
`578`		`-window.console.warn=function(){`
`579`		`-varmsg=Array.prototype.join.call(arguments," ");`
`580`		`-assert.ok(/barf/.test(msg),"Message: "+msg);`
	`578`	`+window.console.warn=function(_intro,error){`
	`579`	`+assert.ok(/barf/.test(error.message+"\n"+error.stack),`
	`580`	`+"Error mentions the method: "+error.message+"\n"+error.stack);`
`581`	`581`	`};`
`582`	`582`
`583`	`583`	`jQuery.when(`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0b9c503

File tree

2 files changed

2 files changed

`‎src/deferred/exceptionHook.js`

`‎test/unit/deferred.js`

0 commit comments