TheholdReady changes LGTM but the ones forjQuery.ready.promise need some more discussion. We currently don't even documentjQuery.ready (onlyjQuery().ready) so that alone is bothersome.

ThejQuery.ready function seems an internal method though. Perhaps this.promise should be moved to somewhere else? Or we could rename this doc file tojQuery.ready and document it as an object with a.promise() method.

Agreed,jQuery.ready is an internal method so putting a public property on it seems like a bad idea. We kind of did it withjQuery.fx.off before but no reason to have bad follow bad. And if we move the location then the whole idea is up for grabs again. Adding an implied dependency on either $.Deferred or a standards-based Promise seems like a bad idea at this point when we're trying to encourage modularity. It's pretty trivial to create your own thenable of any flavor at the application level, right?

I actually think it might be as easy asvar docReady = new Promise(jQuery)

@Krinkle I don't think we want to document the.ready.promise but I do think we want to add the categories to the.holdReady - Going to bring this pull up in the core meeting today to ask opinion from the team.

$.when($.ajax(templateURL),$.ajax(dataURL),$.ready).then(function(template,data){$("#target").html(applyTemplate(template[0],data[0]));});

This is how you decouple initialization code while enabling preemptive asynchronous operations and keeping everything readable. Having apromise method onjQuery.ready makes it a breeze and, yes, it should be documented.

Yes, the ready promise is nice to use. Two issues with it:

• It is in a bad place.jQuery.ready is not a public property or method. If we want a documented ready promise we can put it elsewhere and the jQuery Migrate plugin can warn about the old undocumented use.
• It needs to be really clearly documented this property has a dependency onjQuery.Deferred and excluding that module means the promise won't be created. Unless we do something to use other promise implementations, in which case that also needs to be documented.

Edit by@gnarf - made into checkboxes

Okay,$.when( $.ready ) is super useful, but I think we should make a few changes, do a few checks first here:

• Don't document calling.promise() directly in examples, just use it with$.when( $.ready ).done everywhere
• Ensure the behavior is in a unit test suite somewhere, otherwise, much like my favorite$({}).queue() is probably just an abomination known only to people who have watched our conference talks or read our stack overflow answers...

• We should wait forRemove core/ready hard dependency on $.Deferred jquery#1778 to be figured out also

Is this PR still relevant? It's more than a year old.

@timmywil Could you please check this? Thanks (old PR).

Oh, sorry. It depends on the resolution of the ticket@gnarf linked. I guess it's been longer than I thought, but we finally have aPR for it. I'm on the fence about whether it's worth the bytes. If we merge the PR,jQuery.ready.promise will no longer exist. Instead, we'll probably want to document thatjQuery.ready is "Promise-consumable [opposite of sic]".

Thenable?
On Jan 28, 2016 09:31, "Timmy Willison"notifications@github.com wrote:

Oh, sorry. It depends on the resolution of the ticket@gnarf
https://github.com/gnarf linked. I guess it's been longer than I
thought, but we finally have a PR
jquery/jquery#2850 for it. I'm on the fence
about whether it's worth the bytes. If we merge the PR,
jQuery.ready.promise will no longer exist. Instead, we'll probably want
to document that jQuery.ready is "Promise-consumable [opposite of sic]".

—
Reply to this email directly or view it on GitHub
#530 (comment)
.

It looks like we will be getting rid ofjQuery.ready.promise. I can say with some certainty that we will instead want to documentjQuery.ready as Promise-consumable. As@gnarf said, "thenable" is also appropriate. Example usage would bePromise.resolve(jQuery.ready) with native Promise.

Shouldn't that pull request be merged?https://jquery.com/upgrade-guide/3.0/ says that "Feature: jQuery.ready promise is formally supported" but I don't see it onhttps://api.jquery.com

The PR needs updating first.

jquery/jquery#1778 has been fixed so this PR should no longer be blocked.

@Krinkle With jQuery 3.0 we're exposingjQuery.readyonly as a thenable, so the example here that saysjQuery.ready.done is not supported. There is a non-Deferred alternate module and in that build the code would break. Instead, we're [advising}(https://jquery.com/upgrade-guide/3.0/#feature-jquery-ready-promise-is-formally-supported) that people always usejQuery.when( jQuery.ready ) to convert to a Deferred orPromise.resolve( jQuery.ready ) if someone wanted a native Promise.

Would you like to update this PR to reflect those changes? It would be great to get that done!

@dmethvin Closing this pull request because I deleted and re-forked this repo last year, and there doesn't appear to be anyway to restore the head of a pull request (π). Re-created as#983.