Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Updated cache:true instructions for $.getScript#1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
oriadam wants to merge3 commits intojquery:main
base:main
Choose a base branch
Loading
fromoriadam:master

Conversation

@oriadam
Copy link

@oriadamoriadam commentedJul 5, 2017•
edited
Loading

$.getScript signature of passing a settings object instead of URL string was added on jQuery 1.12.
Added the signature to documentation and updated the related workarounds and examples to include the new signature.
The example with loading jquery-color was edited to support caching, as caching is highly recommended when loading a plugin.

The signature of passing a settings object instead of URL string was added on jQuery 1.12 but not documented.Added the signature and updated the cache related workarounds and examples to reflect the new signature.The example with loading jquery-color was edited to support caching because browser caching is highly recommended when loading a plugin code.
The signature of passing a settings object instead of URL string was added on jQuery 1.12.Added the signature and updated the workarounds and examples to reflect the new signature.The example of loading jquery-color was edited to support caching because browser caching is highly recommended when loading a plugin code.
@oriadamoriadam changed the titleAdd missing signatureUpdated cache:true instructions for $.getScriptDec 5, 2017
@AurelioDeRosa
Copy link
Member

Hi@oriadam, thank you for your contribution. Could you update the examples in your PR to match our style guide? You can find the guide here:https://contribute.jquery.org/style-guide/js/

oriadam reacted with thumbs up emoji

Copy link
Author

@oriadamoriadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JavaScript Style Guide

@oriadam
Copy link
Author

Hi@AurelioDeRosa be glad to :) is it ok now ?

@mgol
Copy link
Member

mgol commentedAug 1, 2018

We don't seem to have a style guide for XML documents. The one that@AurelioDeRosa links to describes only JS. We have an HTML doc but our XML files aren't really close to that.

@oriadam I think all XML files should be aligned with each other so they should all use 2-space indentation.

Base automatically changed frommaster tomainFebruary 1, 2021 22:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dmethvindmethvindmethvin left review comments

@mgolmgolmgol requested changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oriadam@AurelioDeRosa@mgol@dmethvin
[8]ページ先頭
©2009-2025 Movatter.jp