- Notifications
You must be signed in to change notification settings - Fork1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Make object key color configurable (close #1739, #1791, #2638)#2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a3e8a10 to951e04eCompare…qlang#2638)Co-authored-by: David Haguenauer <ml@kurokatta.org>Co-authored-by: Eric Pruitt <eric.pruitt@gmail.com>
emanuele6 approved these changesJul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Thanks! |
Thank you! |
roshal commentedSep 13, 2023
finally awesome
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRresolves#1739 by allowing user to configure object key at the 8th element of
JQ_COLORS. The patch is based on the#1791 and#2638, and my comment#1791 (comment). Also I optimized colors lookup by using enum to int conversion (already used for type comparison).Closes#1791 andcloses#2638.