Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

analysis: allow running without concurrency#11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
joshuasing merged 1 commit intomainfromjoshua/max-concurrent-golangci
Apr 20, 2025

Conversation

joshuasing
Copy link
Owner

@joshuasingjoshuasing commentedApr 20, 2025
edited
Loading

golangci-lint handles concurrency internally, meaning we should avoid creating an unnecessary goroutine and instead allow MaxConcurrent to be set to 0, meaning files should be processed synchronously.

This also optimises for when MaxConcurrent is set to 1, since it is the same as using no concurrency and we can skip using goroutines.

cmd/golicenser keeps the previous default ofGOMAXPROCS * 2 for the MaxConcurrent value.

golangci/golangci-lint@a314c0e (#5751)

@joshuasingjoshuasing added the type: refactorThis improves existing functionality labelApr 20, 2025
@joshuasingjoshuasingforce-pushed thejoshua/max-concurrent-golangci branch 2 times, most recently fromb59438c to3118967CompareApril 20, 2025 05:04
golangci-lint handles concurrency internally, meaning we should avoidcreating an unnecessary goroutine and instead allow MaxConcurrent to beset to 0, meaning files should be processed synchronously.This also optimises for when MaxConcurrent is set to 1, since it is thesame as using no concurrency and we can skip using goroutines.cmd/golicenser keeps the previous default of `runtime.NumCPU() * 2` forthe MaxConcurrent value.
@joshuasingjoshuasingforce-pushed thejoshua/max-concurrent-golangci branch from3118967 to6bacac5CompareApril 20, 2025 05:06
@joshuasingjoshuasing merged commit9f0b55f intomainApr 20, 2025
6 checks passed
@joshuasingjoshuasing deleted the joshua/max-concurrent-golangci branchApril 20, 2025 15:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: refactorThis improves existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@joshuasing

[8]ページ先頭

©2009-2025 Movatter.jp