Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork0
analysis: allow running without concurrency#11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
b59438c
to3118967
Comparegolangci-lint handles concurrency internally, meaning we should avoidcreating an unnecessary goroutine and instead allow MaxConcurrent to beset to 0, meaning files should be processed synchronously.This also optimises for when MaxConcurrent is set to 1, since it is thesame as using no concurrency and we can skip using goroutines.cmd/golicenser keeps the previous default of `runtime.NumCPU() * 2` forthe MaxConcurrent value.
3118967
to6bacac5
Compare9f0b55f
intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
golangci-lint handles concurrency internally, meaning we should avoid creating an unnecessary goroutine and instead allow MaxConcurrent to be set to 0, meaning files should be processed synchronously.
This also optimises for when MaxConcurrent is set to 1, since it is the same as using no concurrency and we can skip using goroutines.
cmd/golicenser keeps the previous default of
GOMAXPROCS * 2
for the MaxConcurrent value.golangci/golangci-lint@
a314c0e
(#5751)