Commitbc2fbde

committed

Fixed bug issue 111. It seems there was a problem in the assignment operators where the parsing was not done correctly, causing undefined behaviour.

1 parent51fe256 commitbc2fbdeCopy full SHA for bc2fbde

File tree

-9

lines changed

-9

lines changed

Lines changed: 5 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,6 @@ class BOOST_URI_DECL uri {`
`45`	`45`
`46`	`46`	`}`
`47`	`47`
`48`		`-//uri(const value_type *uri)`
`49`		`-// : uri_(uri), is_valid_(false) {`
`50`		`-// parse();`
`51`		`-//}`
`52`		`-`
`53`	`48`	`uri(const string_type &uri)`
`54`	`49`	`: uri_(uri), is_valid_(false) {`
`55`	`50`	`parse();`
`@@ -69,13 +64,15 @@ class BOOST_URI_DECL uri {`
`69`	`64`	`}`
`70`	`65`
`71`	`66`	`uri &operator = (const uri &other) {`
`72`		`-uri(other).swap(*this);`
	`67`	`+uri_ = other.uri_;`
	`68`	`+parse();`
`73`	`69`	`return *this;`
`74`	`70`	`}`
`75`	`71`
`76`	`72`	`uri &operator = (const string_type &uri_string) {`
`77`		`-uri(uri_string).swap(*this);`
`78`		`-return *this;`
	`73`	`+uri_ = uri_string;`
	`74`	`+parse();`
	`75`	`+return *this;`
`79`	`76`	`}`
`80`	`77`
`81`	`78`	`~uri() {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -121,8 +121,8 @@ target_link_libraries(hello_world_client`
`121`	`121`	`cppnetlib-http-client`
`122`	`122`	`cppnetlib-http-client-connections)`
`123`	`123`
`124`		`-target_link_libraries(uri_builder${OPENSSL_LIBRARIES})`
`125`	`124`	`if (OPENSSL_FOUND)`
	`125`	`+ target_link_libraries(uri_builder${OPENSSL_LIBRARIES})`
`126`	`126`	`#target_link_libraries(http_client ${OPENSSL_LIBRARIES})`
`127`	`127`	`target_link_libraries(simple_wget${OPENSSL_LIBRARIES})`
`128`	`128`	`target_link_libraries(atom_reader${OPENSSL_LIBRARIES})`

Comments

(0)