Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork200
Added OpenTelemetry REST endpoint for external systems to store logs in Salesforce#767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
jongpie wants to merge8 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
c01b013 to2d5e814Compare…external systems to store logging data in Salesforce, using OpenTelemetry's logs data model
…apped traceId to transactionId, and added more attributes for browser fields, HttpRequest fields, and HttpResponse fields
476eee8 to2d224d2Compare2d224d2 tof0c63dfCompareCodecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #767 +/- ##==========================================+ Coverage 85.97% 91.51% +5.53%========================================== Files 17 59 +42 Lines 1319 6609 +5290 Branches 200 200 ==========================================+ Hits 1134 6048 +4914- Misses 165 541 +376 Partials 20 20
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. |
@anuragoyar it looks like you've copied/pasted some AI-generated reviews of this PR.... any particular reason that you're adding these as comments? |
anengineerdude commentedMay 21, 2025
@anuragoyar #badbot |
OwnerAuthor
jongpie commentedMay 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I... wasn't expecting 4 more AI-generated comments in response tomy question 😅@anuragoyar I'm not sure what's going on with your comments (presumably, you've setup some automated bot that's gone rogue?), but I'm blocking you for now to stop the comments, and I'm hiding/deleting several of your comments as they're just adding noise to this PR. For future reference, here's a giant screenshot of the comments that were added (and then removed).
|
What a mess |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Feature: OpenTelemetry SupportItems to related to supporting OpenTelemetry (OTel) and its standards for observability data Layer: Log ManagementItems related to the custom objects & Logger Console app Layer: Logger EngineItems related to the core logging engine Logging Source: APIItems related to using Nebula Logger via REST API Type: EnhancementNew feature or request
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved#635 by adding a new
LoggerRestResourceApex class that can be called by external systems to store external logging data in Salesforce, using OpenTelemetry's logs data model.For now, this only includes the ability to store logging data, and only a handful of attributes are supported. Future releases will include:
Log__candLogEntry__cGETendpoint that could be used to also retrieve logging data from Salesforce in OpenTelemetry (OTel) format, but the complexity was growing with that effort, so I'll revisit it in a separate PR/release