Conteúdo

Princípio da responsabilidade única

publicfunctiongetFullNameAttribute(){if (auth()->user() &&auth()->user()->hasRole('client') &&auth()->user()->isVerified()) {return'Sr.' .$this->first_name .'' .$this->middle_name .'' .$this->last_name;    }else {return$this->first_name[0] .'.' .$this->last_name;    }}

publicfunctiongetFullNameAttribute(){return$this->isVerifiedClient() ?$this->getFullNameLong() :$this->getFullNameShort();}publicfunctionisVerifiedClient(){returnauth()->user() &&auth()->user()->hasRole('client') &&auth()->user()->isVerified();}publicfunctiongetFullNameLong(){return'Sr.' .$this->first_name .'' .$this->middle_name .'' .$this->last_name;}publicfunctiongetFullNameShort(){return$this->first_name[0] .'.' .$this->last_name;}

Models gordos, controllers finos

publicfunctionindex(){$clients = Client::verified()        ->with(['orders' =>function ($q) {$q->where('created_at','>', Carbon::today()->subWeek());        }])        ->get();returnview('index', ['clients' =>$clients]);}

publicfunctionindex(){returnview('index', ['clients' =>$this->client->getWithNewOrders()]);}class Clientextends Model{publicfunctiongetWithNewOrders()    {return$this->verified()            ->with(['orders' =>function ($q) {$q->where('created_at','>', Carbon::today()->subWeek());            }])            ->get();    }}

Validação

publicfunctionstore(Request$request){$request->validate(['title' =>'required|unique:posts|max:255','body' =>'required','publish_at' =>'nullable|date',    ]);....}

publicfunctionstore(PostRequest$request){....}class PostRequestextends Request{publicfunctionrules()    {return ['title' =>'required|unique:posts|max:255','body' =>'required','publish_at' =>'nullable|date',        ];    }}

Lógica de negócio deve ser posta em classes

publicfunctionstore(Request$request){if ($request->hasFile('image')) {$request->file('image')->move(public_path('images') .'temp');    }....}

publicfunctionstore(Request$request){$this->articleService->handleUploadedImage($request->file('image'));....}class ArticleService{publicfunctionhandleUploadedImage($image)    {if (!is_null($image)) {$image->move(public_path('images') .'temp');        }    }}

Não se repita (Don't repeat yourself: DRY)

publicfunctiongetActive(){return$this->where('verified',1)->whereNotNull('deleted_at')->get();}publicfunctiongetArticles(){return$this->whereHas('user',function ($q) {$q->where('verified',1)->whereNotNull('deleted_at');        })->get();}

publicfunctionscopeActive($q){return$q->where('verified',1)->whereNotNull('deleted_at');}publicfunctiongetActive(){return$this->active()->get();}publicfunctiongetArticles(){return$this->whereHas('user',function ($q) {$q->active();        })->get();}

Usar o Eloquent em vez de Query Builder e consultas SQL puras (raw SQL). Usar collections no lugar de arrays

SELECT*FROM`articles`WHERE EXISTS (SELECT*FROM`users`WHERE`articles`.`user_id`=`users`.`id`AND EXISTS (SELECT*FROM`profiles`WHERE`profiles`.`user_id`=`users`.`id`)AND`users`.`deleted_at` ISNULL)AND`verified`='1'AND`active`='1'ORDER BY`created_at`DESC

Article::has('user.profile')->verified()->latest()->get();

Atribuição em massa

$article =newArticle;$article->title =$request->title;$article->content =$request->content;$article->verified =$request->verified;// Adicionar categoria em artigos$article->category_id =$category->id;$article->save();

$category->article()->create($request->all());

Não executar consultas no Blade templates e usar eager loading (N + 1)

@foreach (User::all()as$user)    {{$user->profile->name }}@endforeach

$users = User::with('profile')->get();...@foreach ($usersas$user)    {{$user->profile->name }}@endforeach

Use chunk para tarefas de dados pesadas

$users =$this->get();foreach ($usersas$user) {...}

$this->chunk(500,function ($users) {foreach ($usersas$user) {...    }});

Comente seu código, mas prefira um método descritivo e nomes de variáveis em vez de comentários

if (count((array)$builder->getQuery()->joins) >0)

// Determine se há algum join.if (count((array)$builder->getQuery()->joins) >0)

if ($this->hasJoins())

Não coloque JS e CSS em templates Blade. Não coloque HTML em classes PHP

let article = `{{ json_encode($article) }}`;

<input type="hidden" value="{{json_encode($article) }}">Ou<button data-article="{{json_encode($article) }}">{{$article->name }}<button>