- Notifications
You must be signed in to change notification settings - Fork18
Ignore a global "module" variable#6
Closed
wrobel wants to merge 1 commit intojhnns:masterfrom
wrobel:master
Closed
Conversation
In case global scope has a variable "module" rewire-webpack will includethis variable into the rewired module using "var module = ...". Thefunction in getImportGlobalsSrc.js is responsible for copying theglobals into such "var ... = ..." definitions.Webpack however starts each module with the following function wrapper:"function(module, exports, __webpack_require__) {...}"Having a "var module = ..." statement within this function will shadowthe module variable.In consequence the module cannot export anything anymore as it exportsto a local variable.This can be fixed by instructing getImportGlobalsSrc() to ignore themodule variable via "getImportGlobalsSrc(["module"])".Owner
jhnns commentedOct 30, 2014
Mhmmm ... you're right. But this is only the case when there is a I'm thinking of ignoring |
Author
wrobel commentedOct 31, 2014
We do have the window.module variable as we pull in angular-mocks for our Karma based tests. I was suprised to see that this seems to be something people did not encounter before when using rewire-webpack in an angular based setup. Ignoring them within |
jhnns added a commit to jhnns/rewire that referenced this pull requestNov 4, 2014
…obal counterpart exists@seejhnns/rewire-webpack#6
Owner
jhnns commentedNov 4, 2014
Released on npm as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case global scope has a variable "module" rewire-webpack will include
this variable into the rewired module using "var module = ...". The
function in getImportGlobalsSrc.js is responsible for copying the
globals into such "var ... = ..." definitions.
Webpack however starts each module with the following function wrapper:
"function(module, exports,webpack_require) {...}"
Having a "var module = ..." statement within this function will shadow
the "module" parameter from the function definition.
In consequence the module cannot export anything anymore as it exports
to a local variable.
This can be fixed by instructing getImportGlobalsSrc() to ignore the
module variable via "getImportGlobalsSrc(["module"])".