Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.9k
fix(package.json):.min suffixes were duplicated forversion-prefixed#3901
Open
rindeal wants to merge 1 commit intojgthms:mainfrom
Open
fix(package.json):.min suffixes were duplicated forversion-prefixed#3901rindeal wants to merge 1 commit intojgthms:mainfrom
.min suffixes were duplicated forversion-prefixed#3901rindeal wants to merge 1 commit intojgthms:mainfrom
Conversation
This change will break only downstream relying on double `.min` suffix files.The rest of downstream will now finally get minified version, when requesting `bulma-prefixed.min.css` instead of getting full version.
.min suffix for version-prefixed.min suffixes were duplicated forversion-prefixed This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This patch corrects the
version-prefixedscript inpackage.jsonby removing the duplicated.minsuffix. The script now correctly outputsbulma-prefixed.cssinstead ofbulma-prefixed.min.css, which was then minified tobulma-prefixed.min.min.css.