- Notifications
You must be signed in to change notification settings - Fork256
fix: outdated cmd wasn't check for real new versions#2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -80,6 +90,32 @@ func (d *Devbox) Outdated(ctx context.Context) (map[string]UpdateVersion, error) | |||
| return outdatedPackages, nil | |||
| } | |||
| // isGreater returns true if v1 is greater than v2 | |||
| func isGreater(v1, v2 string) bool { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wish it was this simple :(
Unfortunately, nix package versions don't follow any convention. Some (many) use semver, but many do not.
We have some pretty complicated logic to try to do this on the search server. I can look into open sourcing it so you can use it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let me know, for now this can be enough for doing this dirty job :)
Uh oh!
There was an error while loading.Please reload this page.
Summary
Previously this only checks on lockfile.
How was it tested?
Manually on a project I'm working on, and I figured out it was not working correctly.