Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[CI Energy Waste] Deduplicate static checks in CI workflow#15739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cpojer merged 2 commits intojestjs:mainfromsouhailaS:deduplicate-static-checks
Jul 18, 2025
Merged
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
NextNext commit
Deduplicate static checks in CI workflow
Combine typecheck, lint, and yarn-validate jobs into a single static-checks job to eliminate duplication of setup steps and dependencies.
  • Loading branch information
@souhailaS
souhailaS committedJul 15, 2025
commita6b2cc7be34f0ce7583dad5e80d203d4048c2de0
41 changes: 5 additions & 36 deletions.github/workflows/nodejs.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,8 +56,8 @@ jobs:
- name: Run tests depending on type information
run: yarn test-with-type-info

typecheck:
name:Typecheck Examples and Tests
static-checks:
name:Static Checks (Lint, Typecheck, Yarn Validate)
runs-on: ubuntu-latest
needs: prepare-yarn-cache-ubuntu

Expand All@@ -71,30 +71,14 @@ jobs:
cache: yarn
- name: install
run: yarn --immutable
- name: build
- name: build TypeScript
run: yarn build:ts
- name: build JavaScript
run: yarn build:js
- name: typecheck examples
run: yarn typecheck:examples
- name: typecheck tests
run: yarn typecheck:tests

lint:
name: Lint
runs-on: ubuntu-latest
needs: prepare-yarn-cache-ubuntu

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: lts/*
cache: yarn
- name: install
run: yarn --immutable
- name: build
run: yarn build:js
- name: verify Yarn PnP compatibility
run: yarn verify-pnp
- name: run eslint
Expand All@@ -105,21 +89,6 @@ jobs:
run: yarn check-changelog
- name: check copyright headers
run: yarn check-copyright-headers

yarn-validate:
name: Validate Yarn dependencies and constraints
runs-on: ubuntu-latest
needs: prepare-yarn-cache-ubuntu
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: lts/*
cache: yarn
- name: install
run: yarn --immutable
- name: 'Check for unmet constraints (fix w/ "yarn constraints --fix")'
run: yarn constraints
- name: 'Check for duplicate dependencies (fix w/ "yarn dedupe")'
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp