Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.6k
AllowtestMatch to take a string value#15734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
linux-foundation-easyclabot commentedJul 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
netlifybot commentedJul 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forjestjs ready!Builtwithout sensitive environment variables
To edit notification comments on pull requests, go to yourNetlify project configuration. |
pkg-pr-newbot commentedJul 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
babel-jestbabel-plugin-jest-hoistbabel-preset-jestcreate-jest@jest/diff-sequencesexpect@jest/expect-utilsjestjest-changed-filesjest-circusjest-clijest-config@jest/console@jest/core@jest/create-cache-key-functionjest-diffjest-docblockjest-each@jest/environmentjest-environment-jsdom@jest/environment-jsdom-abstractjest-environment-node@jest/expect@jest/fake-timers@jest/get-type@jest/globalsjest-haste-mapjest-jasmine2jest-leak-detectorjest-matcher-utilsjest-message-utiljest-mock@jest/patternjest-phabricatorjest-regex-util@jest/reportersjest-resolvejest-resolve-dependenciesjest-runnerjest-runtime@jest/schemasjest-snapshot@jest/snapshot-utils@jest/source-map@jest/test-result@jest/test-sequencer@jest/transform@jest/typesjest-utiljest-validatejest-watcherjest-workerpretty-formatcommit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's a good fix, thank you!
4d57381 intojestjs:mainUh oh!
There was an error while loading.Please reload this page.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Inspired by a mistake I made while modifying the config. I was surprised that
testMatchonly took an array of strings, and not a string value. This struck me as a bit unusual, especially since a similar option,testRegex, takesstring | string[].Test plan
Wrote a test case for the
normalizefunction to assert that"some string"gets transformed to["some string"].