Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Globals cleanup: avoid setting protection symbol when feature is off#15684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@eyalroth
Copy link
Contributor

@eyalrotheyalroth commentedJun 18, 2025•
edited
Loading

Summary

Fixes#15678.

First commit also makes sure to runjest-environment-node tests will every combination of theglobalsCleanup configuration.

EDM115 reacted with eyes emoji
@netlify
Copy link

netlifybot commentedJun 18, 2025•
edited
Loading

✅ Deploy Preview forjestjs ready!

Builtwithout sensitive environment variables

NameLink
🔨 Latest commit429cf37
🔍 Latest deploy loghttps://app.netlify.com/projects/jestjs/deploys/6852bd22a8ad4100081b1d24
😎 Deploy Previewhttps://deploy-preview-15684--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-newbot commentedJun 18, 2025•
edited
Loading

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15684

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15684

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15684

create-jest

npm i https://pkg.pr.new/create-jest@15684

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15684

expect

npm i https://pkg.pr.new/expect@15684

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15684

jest

npm i https://pkg.pr.new/jest@15684

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15684

jest-circus

npm i https://pkg.pr.new/jest-circus@15684

jest-cli

npm i https://pkg.pr.new/jest-cli@15684

jest-config

npm i https://pkg.pr.new/jest-config@15684

@jest/console

npm i https://pkg.pr.new/@jest/console@15684

@jest/core

npm i https://pkg.pr.new/@jest/core@15684

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15684

jest-diff

npm i https://pkg.pr.new/jest-diff@15684

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15684

jest-each

npm i https://pkg.pr.new/jest-each@15684

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15684

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15684

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15684

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15684

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15684

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15684

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15684

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15684

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15684

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15684

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15684

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15684

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15684

jest-mock

npm i https://pkg.pr.new/jest-mock@15684

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15684

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15684

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15684

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15684

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15684

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15684

jest-runner

npm i https://pkg.pr.new/jest-runner@15684

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15684

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15684

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15684

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15684

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15684

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15684

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15684

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15684

@jest/types

npm i https://pkg.pr.new/@jest/types@15684

jest-util

npm i https://pkg.pr.new/jest-util@15684

jest-validate

npm i https://pkg.pr.new/jest-validate@15684

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15684

jest-worker

npm i https://pkg.pr.new/jest-worker@15684

pretty-format

npm i https://pkg.pr.new/pretty-format@15684

commit:429cf37

@eyalrotheyalrothforce-pushed the15678-globalscleanup-off-no-protection branch from40a9867 to760523aCompareJune 18, 2025 12:46
@eyalrotheyalrothforce-pushed the15678-globalscleanup-off-no-protection branch from760523a to429cf37CompareJune 18, 2025 13:20
@eyalrotheyalroth marked this pull request as ready for reviewJune 18, 2025 13:36
@eyalroth
Copy link
ContributorAuthor

@cpojer not sure if you saw but this PR is ready for review :)

(I can't seem to be able to use the "request review" feature)

Copy link
Member

@cpojercpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you, I'll publish a new release.

eyalroth reacted with hooray emoji
@cpojercpojer merged commit33820ad intojestjs:mainJun 18, 2025
74 of 76 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend usingStackOverflow or ourdiscord channel for questions.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@cpojercpojercpojer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: globalsCleanup causes issues with some deps, can't be properly turned off

2 participants

@eyalroth@cpojer
[8]ページ先頭
©2009-2025 Movatter.jp